Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: third_party/WebKit/Source/modules/geolocation/Geolocation.cpp

Issue 2733093003: DevTools: instrument user callbacks based on generic probes, remove NativeBreakpoint. (Closed)
Patch Set: test fixed Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/geolocation/Geolocation.cpp
diff --git a/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp b/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp
index e9f6dafeca73a4e41d96d1abbe4a0da63bc06a2b..210b7c5a32b98f910b09ba13a8ff66df465fe707 100644
--- a/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp
+++ b/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp
@@ -180,7 +180,7 @@ void Geolocation::getCurrentPosition(PositionCallback* successCallback,
return;
reportGeolocationViolation(document());
- probe::breakIfNeeded(document(), "Geolocation.getCurrentPosition");
+ probe::breakableLocation(document(), "Geolocation.getCurrentPosition");
GeoNotifier* notifier =
GeoNotifier::create(this, successCallback, errorCallback, options);
@@ -196,7 +196,7 @@ int Geolocation::watchPosition(PositionCallback* successCallback,
return 0;
reportGeolocationViolation(document());
- probe::breakIfNeeded(document(), "Geolocation.watchPosition");
+ probe::breakableLocation(document(), "Geolocation.watchPosition");
GeoNotifier* notifier =
GeoNotifier::create(this, successCallback, errorCallback, options);

Powered by Google App Engine
This is Rietveld 408576698