third_party/WebKit/Source/core/dom/Document.cpp - Issue 2733093003: DevTools: instrument user callbacks based on generic probes, remove NativeBreakpoint.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 2733093003: DevTools: instrument user callbacks based on generic probes, remove NativeBreakpoint. (Closed)

Patch Set: test fixed Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Document.cpp

diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp

index 58de534754dd9b8b3741f0c6bb31b2234003b7e2..ac763fb3f8ac29acdd134bc9a73b2911c88f4eeb 100644

--- a/third_party/WebKit/Source/core/dom/Document.cpp

+++ b/third_party/WebKit/Source/core/dom/Document.cpp

@@ -3236,7 +3236,7 @@ void Document::write(const SegmentedString& text,

PerformanceMonitor::reportGenericViolation(

this, PerformanceMonitor::kDiscouragedAPIUse,

"Avoid using document.write().", 0, nullptr);

- probe::breakIfNeeded(this, "Document.write");

+ probe::breakableLocation(this, "Document.write");

m_parser->insert(text);

}