third_party/WebKit/Source/core/frame/DOMWindow.cpp - Issue 2733093003: DevTools: instrument user callbacks based on generic probes, remove NativeBreakpoint.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/DOMWindow.cpp

Issue 2733093003: DevTools: instrument user callbacks based on generic probes, remove NativeBreakpoint. (Closed)

Patch Set: test fixed Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/DOMWindow.cpp

diff --git a/third_party/WebKit/Source/core/frame/DOMWindow.cpp b/third_party/WebKit/Source/core/frame/DOMWindow.cpp

index 70fbd25aa5417554db46c63c5c06aa09cbfb30af..b65fc3d37f617f964c41cf1f1840167eb4fcccce 100644

--- a/third_party/WebKit/Source/core/frame/DOMWindow.cpp

+++ b/third_party/WebKit/Source/core/frame/DOMWindow.cpp

@@ -378,7 +378,7 @@ void DOMWindow::close(ExecutionContext* context) {

if (!frame()->shouldClose())

return;

- probe::breakIfNeeded(context, "DOMWindow.close");

+ probe::breakableLocation(context, "DOMWindow.close");

page->closeSoon();