third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp - Issue 2733093003: DevTools: instrument user callbacks based on generic probes, remove NativeBreakpoint.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp

Issue 2733093003: DevTools: instrument user callbacks based on generic probes, remove NativeBreakpoint. (Closed)

Patch Set: test fixed Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp

index f839a2284ddb7093662763af50edd3e7f5ac2db4..130ecb68c3a0089f925b54f7e04be113803ff126 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp

@@ -126,9 +126,6 @@ v8::Local<v8::Value> ScriptController::executeScriptAndReturnValue(

TRACE_EVENT1("devtools.timeline", "EvaluateScript", "data",

InspectorEvaluateScriptEvent::data(

frame(), source.url().getString(), source.startPosition()));

- probe::NativeBreakpoint nativeBreakpoint(frame()->document(),

- "scriptFirstStatement");

v8::Local<v8::Value> result;

{

V8CacheOptions v8CacheOptions =