Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorInstrumentation.h

Issue 2733093003: DevTools: instrument user callbacks based on generic probes, remove NativeBreakpoint. (Closed)
Patch Set: test fixed Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorInstrumentation.h
diff --git a/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.h b/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.h
index ff9706fbe704fffdd01854af01f081ab71786286..72803aa8826c20500ed6f96fb021325162837618 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.h
+++ b/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.h
@@ -59,31 +59,17 @@ class CORE_EXPORT ProbeBase {
mutable double m_endTime = 0;
};
-class CORE_EXPORT NativeBreakpoint {
- STACK_ALLOCATED();
-
- public:
- NativeBreakpoint(ExecutionContext*, const char* name);
- NativeBreakpoint(ExecutionContext*, EventTarget*, Event*);
- ~NativeBreakpoint();
-
- private:
- Member<InstrumentingAgents> m_instrumentingAgents;
-};
-
class CORE_EXPORT AsyncTask {
STACK_ALLOCATED();
public:
AsyncTask(ExecutionContext*, void* task);
AsyncTask(ExecutionContext*, void* task, bool enabled);
- AsyncTask(ExecutionContext*, void* task, const char* breakpointName);
~AsyncTask();
private:
ThreadDebugger* m_debugger;
void* m_task;
- NativeBreakpoint m_breakpoint;
};
// Called from generated instrumentation code.
@@ -124,8 +110,6 @@ inline InstrumentingAgents* instrumentingAgentsFor(EventTarget* eventTarget) {
: nullptr;
}
-CORE_EXPORT void breakIfNeeded(ExecutionContext*, const char* name);
-
CORE_EXPORT void asyncTaskScheduled(ExecutionContext*,
const String& name,
void*,

Powered by Google App Engine
This is Rietveld 408576698