Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(48)

Issue 2718643002: Worker: Pass ParentFrameTaskRunners via WorkerThread::start() instead of the ctor (Closed)

Created:
9 months, 2 weeks ago by nhiroki
Modified:
9 months, 2 weeks ago
Reviewers:
haraken
CC:
chromium-reviews, shans, tzik, kinuko+worker_chromium.org, kinuko+watch, jsbell+serviceworker_chromium.org, hongchan, blink-reviews, falken+watch_chromium.org, blink-worker-reviews_chromium.org, Eric Willigers, rjwright, nhiroki, Raymond Toy, darktears, michaeln, shimazu+serviceworker_chromium.org, blink-reviews-animation_chromium.org, serviceworker-reviews, shimazu+worker_chromium.org, kinuko+serviceworker, horo+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Worker: Pass ParentFrameTaskRunners via WorkerThread::start() instead of the ctor This is a cleanup and should not change behavior. ParentFrameTaskRunners is never used before WorkerThread::start() is called so we don't have to pass it via the ctor of WorkerThread. This drastically simplifies code and enables us to modify thread infra with a smaller number of file changes. BUG=694914 Review-Url: https://codereview.chromium.org/2718643002 Cr-Commit-Position: refs/heads/master@{#453096} Committed: https://chromium.googlesource.com/chromium/src/+/98eb8962d85b8c426602f89e6e31358b40e46bab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -169 lines) Patch
M third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/workers/DedicatedWorkerMessagingProxy.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp View 3 chunks +11 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/workers/DedicatedWorkerThread.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/DedicatedWorkerThread.cpp View 1 chunk +3 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/workers/SharedWorkerThread.h View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/workers/SharedWorkerThread.cpp View 1 chunk +5 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/ThreadedWorkletTest.cpp View 3 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThread.h View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThread.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp View 3 chunks +10 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h View 3 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/AbstractAnimationWorkletThread.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/AbstractAnimationWorkletThread.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/AnimationWorkletMessagingProxy.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThread.h View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThread.cpp View 1 chunk +5 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThreadTest.cpp View 1 chunk +8 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerMessagingProxy.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThread.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThread.cpp View 1 chunk +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp View 1 chunk +8 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerThread.h View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerThread.cpp View 1 chunk +4 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioWorkletMessagingProxy.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioWorkletThread.h View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioWorkletThread.cpp View 1 chunk +4 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioWorkletThreadTest.cpp View 3 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
Trybot results:  ios-simulator   ios-simulator-xcode-clang   win_clang   win_chromium_compile_dbg_ng   win_chromium_x64_rel_ng   mac_chromium_rel_ng   mac_chromium_compile_dbg_ng   win_chromium_rel_ng   linux_chromium_tsan_rel_ng   ios-device   linux_chromium_asan_rel_ng   cast_shell_android   linux_chromium_compile_dbg_ng   linux_android_rel_ng   linux_chromium_rel_ng   ios-simulator   chromeos_daisy_chromium_compile_only_ng   cast_shell_linux   android_compile_dbg   android_arm64_dbg_recipe   android_cronet   android_n5x_swarming_rel   chromeos_amd64-generic_chromium_compile_only_ng   chromium_presubmit   linux_chromium_chromeos_ozone_rel_ng   android_clang_dbg_recipe   linux_chromium_chromeos_rel_ng   ios-device-xcode-clang   linux_chromium_rel_ng   mac_chromium_rel_ng   chromium_presubmit   win_chromium_rel_ng   win_clang   linux_chromium_chromeos_rel_ng   win_chromium_compile_dbg_ng   linux_chromium_chromeos_ozone_rel_ng   chromeos_amd64-generic_chromium_compile_only_ng   win_chromium_x64_rel_ng   linux_chromium_rel_ng   ios-device-xcode-clang   android_cronet   linux_chromium_asan_rel_ng   cast_shell_linux   cast_shell_android   ios-simulator   android_compile_dbg   ios-simulator-xcode-clang   linux_chromium_tsan_rel_ng   mac_chromium_rel_ng   android_clang_dbg_recipe   ios-device   mac_chromium_compile_dbg_ng   linux_android_rel_ng   android_n5x_swarming_rel   chromeos_daisy_chromium_compile_only_ng   linux_chromium_compile_dbg_ng   android_arm64_dbg_recipe 

Dependent Patchsets:

Messages

Total messages: 15 (11 generated)
nhiroki
PTAL, thanks!
9 months, 2 weeks ago (2017-02-24 09:35:29 UTC) #7
haraken
LGTM
9 months, 2 weeks ago (2017-02-25 00:33:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718643002/1
9 months, 2 weeks ago (2017-02-25 15:21:15 UTC) #12
commit-bot: I haz the power
9 months, 2 weeks ago (2017-02-25 17:03:29 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/98eb8962d85b8c426602f89e6e31...

Powered by Google App Engine
This is Rietveld 0eb02b776