Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Unified Diff: third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h

Issue 2718643002: Worker: Pass ParentFrameTaskRunners via WorkerThread::start() instead of the ctor (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h
diff --git a/third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h b/third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h
index a5f69a82d30b0c39ad55773db78df61eaec7ccf6..f93d0b8e88ad0de36740fd60e1e47f295051d440 100644
--- a/third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h
+++ b/third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h
@@ -119,11 +119,9 @@ class MockWorkerThreadLifecycleObserver final
class WorkerThreadForTest : public WorkerThread {
public:
WorkerThreadForTest(WorkerLoaderProxyProvider* mockWorkerLoaderProxyProvider,
- WorkerReportingProxy& mockWorkerReportingProxy,
- ParentFrameTaskRunners* parentFrameTaskRunners)
+ WorkerReportingProxy& mockWorkerReportingProxy)
: WorkerThread(WorkerLoaderProxy::create(mockWorkerLoaderProxyProvider),
- mockWorkerReportingProxy,
- parentFrameTaskRunners),
+ mockWorkerReportingProxy),
m_workerBackingThread(
WorkerBackingThread::createForTest("Test thread")) {}
@@ -138,7 +136,8 @@ class WorkerThreadForTest : public WorkerThread {
std::unique_ptr<WorkerThreadStartupData>) override;
void startWithSourceCode(SecurityOrigin* securityOrigin,
- const String& source) {
+ const String& source,
+ ParentFrameTaskRunners* parentFrameTaskRunners) {
std::unique_ptr<Vector<CSPHeaderAndType>> headers =
WTF::makeUnique<Vector<CSPHeaderAndType>>();
CSPHeaderAndType headerAndType("contentSecurityPolicy",
@@ -148,10 +147,11 @@ class WorkerThreadForTest : public WorkerThread {
WorkerClients* clients = nullptr;
start(WorkerThreadStartupData::create(
- KURL(ParsedURLString, "http://fake.url/"), "fake user agent", source,
- nullptr, DontPauseWorkerGlobalScopeOnStart, headers.get(), "",
- securityOrigin, clients, WebAddressSpaceLocal, nullptr, nullptr,
- WorkerV8Settings::Default()));
+ KURL(ParsedURLString, "http://fake.url/"), "fake user agent",
+ source, nullptr, DontPauseWorkerGlobalScopeOnStart, headers.get(),
+ "", securityOrigin, clients, WebAddressSpaceLocal, nullptr,
+ nullptr, WorkerV8Settings::Default()),
+ parentFrameTaskRunners);
}
void waitForInit() {

Powered by Google App Engine
This is Rietveld 408576698