Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Side by Side Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerThread.cpp

Issue 2718643002: Worker: Pass ParentFrameTaskRunners via WorkerThread::start() instead of the ctor (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 22 matching lines...) Expand all
33 #include "core/workers/WorkerBackingThread.h" 33 #include "core/workers/WorkerBackingThread.h"
34 #include "core/workers/WorkerThreadStartupData.h" 34 #include "core/workers/WorkerThreadStartupData.h"
35 #include "modules/serviceworkers/ServiceWorkerGlobalScope.h" 35 #include "modules/serviceworkers/ServiceWorkerGlobalScope.h"
36 #include "wtf/PtrUtil.h" 36 #include "wtf/PtrUtil.h"
37 #include <memory> 37 #include <memory>
38 38
39 namespace blink { 39 namespace blink {
40 40
41 std::unique_ptr<ServiceWorkerThread> ServiceWorkerThread::create( 41 std::unique_ptr<ServiceWorkerThread> ServiceWorkerThread::create(
42 PassRefPtr<WorkerLoaderProxy> workerLoaderProxy, 42 PassRefPtr<WorkerLoaderProxy> workerLoaderProxy,
43 WorkerReportingProxy& workerReportingProxy, 43 WorkerReportingProxy& workerReportingProxy) {
44 ParentFrameTaskRunners* parentFrameTaskRunners) {
45 return WTF::wrapUnique(new ServiceWorkerThread(std::move(workerLoaderProxy), 44 return WTF::wrapUnique(new ServiceWorkerThread(std::move(workerLoaderProxy),
46 workerReportingProxy, 45 workerReportingProxy));
47 parentFrameTaskRunners));
48 } 46 }
49 47
50 ServiceWorkerThread::ServiceWorkerThread( 48 ServiceWorkerThread::ServiceWorkerThread(
51 PassRefPtr<WorkerLoaderProxy> workerLoaderProxy, 49 PassRefPtr<WorkerLoaderProxy> workerLoaderProxy,
52 WorkerReportingProxy& workerReportingProxy, 50 WorkerReportingProxy& workerReportingProxy)
53 ParentFrameTaskRunners* parentFrameTaskRunners) 51 : WorkerThread(std::move(workerLoaderProxy), workerReportingProxy),
54 : WorkerThread(std::move(workerLoaderProxy),
55 workerReportingProxy,
56 parentFrameTaskRunners),
57 m_workerBackingThread( 52 m_workerBackingThread(
58 WorkerBackingThread::create("ServiceWorker Thread")) {} 53 WorkerBackingThread::create("ServiceWorker Thread")) {}
59 54
60 ServiceWorkerThread::~ServiceWorkerThread() {} 55 ServiceWorkerThread::~ServiceWorkerThread() {}
61 56
62 void ServiceWorkerThread::clearWorkerBackingThread() { 57 void ServiceWorkerThread::clearWorkerBackingThread() {
63 m_workerBackingThread = nullptr; 58 m_workerBackingThread = nullptr;
64 } 59 }
65 60
66 WorkerOrWorkletGlobalScope* ServiceWorkerThread::createWorkerGlobalScope( 61 WorkerOrWorkletGlobalScope* ServiceWorkerThread::createWorkerGlobalScope(
67 std::unique_ptr<WorkerThreadStartupData> startupData) { 62 std::unique_ptr<WorkerThreadStartupData> startupData) {
68 return ServiceWorkerGlobalScope::create(this, std::move(startupData)); 63 return ServiceWorkerGlobalScope::create(this, std::move(startupData));
69 } 64 }
70 65
71 } // namespace blink 66 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698