Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2716853002: (WIP) Worker: Merge ParentFrameTaskRunners into TaskRunnerHelper

Created:
3 years, 10 months ago by nhiroki
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, kinuko+worker_chromium.org, shans, rjwright, blink-reviews-animation_chromium.org, sof, eae+blinkwatch, shimazu+worker_chromium.org, haraken, blink-reviews-dom_chromium.org, dglazkov+blink, hongchan, Raymond Toy, darktears, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, Eric Willigers, kinuko+watch, blink-worker-reviews_chromium.org, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

(WIP) Worker: Merge ParentFrameTaskRunners into TaskRunnerHelper TODO - Delete ParentFrameTaskRunners - Replace TaskRunnerHelper with FrameTaskRunnerHelper BUG=

Patch Set 1 #

Patch Set 2 : WIP #

Patch Set 3 : WIP #

Patch Set 4 : WIP #

Patch Set 5 : WIP #

Unified diffs Side-by-side diffs Delta from patch set Stats (+306 lines, -347 lines) Patch
M third_party/WebKit/Source/core/dom/TaskRunnerHelper.h View 1 2 4 chunks +54 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/TaskRunnerHelper.cpp View 1 2 3 3 chunks +94 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.h View 1 2 3 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp View 1 2 3 5 chunks +4 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp View 3 chunks +4 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/workers/BUILD.gn View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp View 1 3 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.h View 3 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp View 1 2 9 chunks +12 lines, -18 lines 0 comments Download
D third_party/WebKit/Source/core/workers/ParentFrameTaskRunners.h View 1 2 3 1 chunk +0 lines, -63 lines 0 comments Download
D third_party/WebKit/Source/core/workers/ParentFrameTaskRunners.cpp View 1 2 3 1 chunk +0 lines, -43 lines 0 comments Download
M third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.h View 1 2 3 3 chunks +1 line, -8 lines 0 comments Download
M third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.cpp View 1 2 3 4 chunks +4 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/workers/ThreadedObjectProxyBase.h View 1 2 3 chunks +4 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/workers/ThreadedObjectProxyBase.cpp View 4 chunks +15 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/workers/ThreadedWorkletMessagingProxy.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/ThreadedWorkletObjectProxy.h View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/workers/ThreadedWorkletObjectProxy.cpp View 2 chunks +4 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/workers/ThreadedWorkletTest.cpp View 1 2 3 5 chunks +5 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThread.h View 1 2 3 4 5 chunks +5 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThread.cpp View 1 2 6 chunks +14 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp View 5 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThreadTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp View 6 chunks +5 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioWorkletThreadTest.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h View 1 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp View 1 5 chunks +4 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.h View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp View 1 2 3 4 chunks +9 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.h View 1 2 3 4 2 chunks +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp View 1 2 3 4 5 chunks +12 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerReportingProxyImpl.h View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerReportingProxyImpl.cpp View 1 2 3 4 7 chunks +20 lines, -15 lines 0 comments Download

Messages

Total messages: 17 (17 generated)
nhiroki
Description was changed from ========== (WIP) Worker: Merge ParentFrameTaskRunners into TaskRunnerHelper BUG= ========== to ========== ...
3 years, 10 months ago (2017-02-24 10:51:53 UTC) #1
nhiroki
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
3 years, 10 months ago (2017-02-24 10:54:48 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2716853002/1
3 years, 10 months ago (2017-02-24 10:55:06 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-24 12:02:18 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/328618)
3 years, 10 months ago (2017-02-24 12:02:19 UTC) #5
nhiroki
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-02-27 02:42:48 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2716853002/20001
3 years, 9 months ago (2017-02-27 02:43:06 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-02-27 03:17:46 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/395973)
3 years, 9 months ago (2017-02-27 03:17:46 UTC) #9
nhiroki
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-02-27 05:25:08 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2716853002/40001
3 years, 9 months ago (2017-02-27 05:25:22 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-02-27 06:26:19 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_tsan_rel_ng/builds/22484)
3 years, 9 months ago (2017-02-27 06:26:19 UTC) #13
nhiroki
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-02-27 07:57:45 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2716853002/60001
3 years, 9 months ago (2017-02-27 07:58:02 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-02-27 08:54:12 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 08:54:13 UTC) #17 
Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Powered by Google App Engine
This is Rietveld 408576698