third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerThread.h - Issue 2718643002: Worker: Pass ParentFrameTaskRunners via WorkerThread::start() instead of the ctor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerThread.h

Issue 2718643002: Worker: Pass ParentFrameTaskRunners via WorkerThread::start() instead of the ctor (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerThread.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerThread.h

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerThread.h b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerThread.h

index 464070ae30b57c7b4bf09002142c2f02a6e2bd3d..a11b72138cc4ac5482ce721c3b71884d22f4f3c6 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerThread.h

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerThread.h

@@ -43,8 +43,7 @@ class MODULES_EXPORT ServiceWorkerThread final : public WorkerThread {

public:

static std::unique_ptr<ServiceWorkerThread> create(

PassRefPtr<WorkerLoaderProxy>,

- WorkerReportingProxy&,

- ParentFrameTaskRunners*);

+ WorkerReportingProxy&);

~ServiceWorkerThread() override;

WorkerBackingThread& workerBackingThread() override {

@@ -57,9 +56,7 @@ class MODULES_EXPORT ServiceWorkerThread final : public WorkerThread {

std::unique_ptr<WorkerThreadStartupData>) override;

private:

- ServiceWorkerThread(PassRefPtr<WorkerLoaderProxy>,

- WorkerReportingProxy&,

- ParentFrameTaskRunners*);

+ ServiceWorkerThread(PassRefPtr<WorkerLoaderProxy>, WorkerReportingProxy&);

std::unique_ptr<WorkerBackingThread> m_workerBackingThread;

};