Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Unified Diff: third_party/WebKit/Source/core/workers/ThreadedWorkletTest.cpp

Issue 2718643002: Worker: Pass ParentFrameTaskRunners via WorkerThread::start() instead of the ctor (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/workers/ThreadedWorkletTest.cpp
diff --git a/third_party/WebKit/Source/core/workers/ThreadedWorkletTest.cpp b/third_party/WebKit/Source/core/workers/ThreadedWorkletTest.cpp
index 2d4187b5f8f1b8ef48a1f999cb625cae0862fd0c..45dc2320efc8d2271a4ce525e74c5044b18a2bae 100644
--- a/third_party/WebKit/Source/core/workers/ThreadedWorkletTest.cpp
+++ b/third_party/WebKit/Source/core/workers/ThreadedWorkletTest.cpp
@@ -23,11 +23,9 @@ class ThreadedWorkletThreadForTest : public WorkerThread {
public:
ThreadedWorkletThreadForTest(
WorkerLoaderProxyProvider* workerLoaderProxyProvider,
- WorkerReportingProxy& workerReportingProxy,
- ParentFrameTaskRunners* parentFrameTaskRunners)
+ WorkerReportingProxy& workerReportingProxy)
: WorkerThread(WorkerLoaderProxy::create(workerLoaderProxyProvider),
- workerReportingProxy,
- parentFrameTaskRunners) {}
+ workerReportingProxy) {}
~ThreadedWorkletThreadForTest() override{};
WorkerBackingThread& workerBackingThread() override {
@@ -95,8 +93,7 @@ class ThreadedWorkletMessagingProxyForTest
m_mockWorkerLoaderProxyProvider =
WTF::makeUnique<MockWorkerLoaderProxyProvider>();
m_workerThread = WTF::makeUnique<ThreadedWorkletThreadForTest>(
- m_mockWorkerLoaderProxyProvider.get(), workletObjectProxy(),
- getParentFrameTaskRunners());
+ m_mockWorkerLoaderProxyProvider.get(), workletObjectProxy());
ThreadedWorkletThreadForTest::ensureSharedBackingThread();
}
@@ -116,12 +113,15 @@ class ThreadedWorkletMessagingProxyForTest
WorkerClients* workerClients = nullptr;
Vector<String> originTrialTokens;
std::unique_ptr<WorkerSettings> workerSettings = nullptr;
- m_workerThread->start(WorkerThreadStartupData::create(
- scriptURL, "fake user agent", "// fake source code",
- std::move(cachedMetaData), DontPauseWorkerGlobalScopeOnStart,
- &contentSecurityPolicyHeaders, referrerPolicy, m_securityOrigin.get(),
- workerClients, WebAddressSpaceLocal, &originTrialTokens,
- std::move(workerSettings), WorkerV8Settings::Default()));
+ m_workerThread->start(
+ WorkerThreadStartupData::create(
+ scriptURL, "fake user agent", "// fake source code",
+ std::move(cachedMetaData), DontPauseWorkerGlobalScopeOnStart,
+ &contentSecurityPolicyHeaders, referrerPolicy,
+ m_securityOrigin.get(), workerClients, WebAddressSpaceLocal,
+ &originTrialTokens, std::move(workerSettings),
+ WorkerV8Settings::Default()),
+ getParentFrameTaskRunners());
workerInspectorProxy()->workerThreadCreated(
toDocument(getExecutionContext()), m_workerThread.get(), scriptURL);
}

Powered by Google App Engine
This is Rietveld 408576698