Added a quick heuristic to determine which objects are the target of in-page links and stop ignorin…

Added a quick heuristic to determine which objects are the target of in-page links and stop ignoring them for purposes of accessibility.

Windows screen readers were getting confused if the object to which an in-page link scrolled to was not an actual link target.
BUG=37721
R=dmazzoni@chromium.org
TESTED=manual testing with file attached to bug
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2713193003
Cr-Commit-Position: refs/heads/master@{#461530}
Committed: https://chromium.googlesource.com/chromium/src/+/9ddb2190fe84221506e9ada748bbea36f45b050d

[nektarios, 2017-02-25 00:42:17]

The CQ bit was checked by nektar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-25 00:42:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-25 00:44:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-25 00:44:39]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[nektarios, 2017-02-25 00:50:43]

The CQ bit was checked by nektar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-25 00:50:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-25 00:52:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-25 00:52:20]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dmazzoni, 2017-02-27 20:06:40]

lgtm

This is fine with me, it's really just a question of it it breaks
a bunch of tests.

[nektarios, 2017-02-27 23:25:00]

The CQ bit was checked by nektar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 23:25:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 00:10:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 00:10:33]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[nektarios, 2017-03-14 20:55:26]

The CQ bit was checked by nektar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 20:56:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 21:39:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 21:39:27]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nektarios, 2017-03-17 01:37:45]

The CQ bit was checked by nektar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 01:38:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 02:11:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 02:11:53]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nektarios, 2017-03-18 22:10:30]

The CQ bit was checked by nektar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-18 22:10:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-18 22:47:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-18 22:47:02]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nektarios, 2017-03-18 23:14:49]

The CQ bit was checked by nektar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-18 23:15:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-18 23:49:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-18 23:49:35]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nektarios, 2017-03-21 18:41:53]

The CQ bit was checked by nektar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 18:42:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 19:23:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 19:23:36]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nektarios, 2017-03-22 02:25:26]

The CQ bit was checked by nektar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 02:26:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 03:03:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 03:03:59]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[nektarios, 2017-03-22 14:42:16]

The CQ bit was checked by nektar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 14:42:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 15:32:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 15:32:49]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nektarios, 2017-03-23 19:59:23]

The CQ bit was checked by nektar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 19:59:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 20:42:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 20:42:07]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dmazzoni, 2017-03-29 15:28:29]

Ping, did you want to finish this one?

[nektarios, 2017-03-29 20:39:44]

The CQ bit was checked by nektar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 20:40:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[blink-reviews, 2017-03-29 21:02:20]

Yes, most of the tests were fixed a while back.
However, one test is still bugging me:
data:text/html,<div id="live" aria-live="polite" aria-atomic="true"> 
<div id="a"></div><div id="b">Bravo</div><div id="c"></div> </div> 
<button id="go">Go</button> <script> 
document.getElementById('go').addEventListener('click', function() { 
document.getElementById('c').textContent = 'Charlie'; 
document.getElementById('a').textContent = 'Alpha'; }, false);
</script>
It fails on Chromevox Next, meanin that "Alpha, bravo, charly" are not 
announced as expected. Since this test has no link tarets in it, I can't 
fiure out why.

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2017-03-29 21:02:21]

Yes, most of the tests were fixed a while back.
However, one test is still bugging me:
data:text/html,<div id="live" aria-live="polite" aria-atomic="true"> 
<div id="a"></div><div id="b">Bravo</div><div id="c"></div> </div> 
<button id="go">Go</button> <script> 
document.getElementById('go').addEventListener('click', function() { 
document.getElementById('c').textContent = 'Charlie'; 
document.getElementById('a').textContent = 'Alpha'; }, false);
</script>
It fails on Chromevox Next, meanin that "Alpha, bravo, charly" are not 
announced as expected. Since this test has no link tarets in it, I can't 
fiure out why.

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dmazzoni, 2017-03-29 21:38:26]

OK, I think what's happening is that the tree change events we're getting
are different now - instead of the changes to the two elements being
handled together, they're being handled separately
The simplest hack to just avoid breaking the test would be to get rid of
the id attribute and use some other attribute to identify the two divs,
using querySelector. Does that make sense?


On Wed, Mar 29, 2017 at 2:02 PM 'Nektarios Paisios' via Chromium-reviews <
chromium-reviews@chromium.org> wrote:

> Yes, most of the tests were fixed a while back.
> However, one test is still bugging me:
> data:text/html,<div id="live" aria-live="polite" aria-atomic="true">
> <div id="a"></div><div id="b">Bravo</div><div id="c"></div> </div>
> <button id="go">Go</button> <script>
> document.getElementById('go').addEventListener('click', function() {
> document.getElementById('c').textContent = 'Charlie';
> document.getElementById('a').textContent = 'Alpha'; }, false);
> </script>
> It fails on Chromevox Next, meanin that "Alpha, bravo, charly" are not
> announced as expected. Since this test has no link tarets in it, I can't
> fiure out why.
>
> --
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[dmazzoni, 2017-03-29 21:38:26]

OK, I think what's happening is that the tree change events we're getting
are different now - instead of the changes to the two elements being
handled together, they're being handled separately
The simplest hack to just avoid breaking the test would be to get rid of
the id attribute and use some other attribute to identify the two divs,
using querySelector. Does that make sense?


On Wed, Mar 29, 2017 at 2:02 PM 'Nektarios Paisios' via Chromium-reviews <
chromium-reviews@chromium.org> wrote:

> Yes, most of the tests were fixed a while back.
> However, one test is still bugging me:
> data:text/html,<div id="live" aria-live="polite" aria-atomic="true">
> <div id="a"></div><div id="b">Bravo</div><div id="c"></div> </div>
> <button id="go">Go</button> <script>
> document.getElementById('go').addEventListener('click', function() {
> document.getElementById('c').textContent = 'Charlie';
> document.getElementById('a').textContent = 'Alpha'; }, false);
> </script>
> It fails on Chromevox Next, meanin that "Alpha, bravo, charly" are not
> announced as expected. Since this test has no link tarets in it, I can't
> fiure out why.
>
> --
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2017-03-29 21:43:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 21:43:37]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nektarios, 2017-03-29 22:00:36]

Description was changed from

==========
Added a quick heuristic to determine which objects are the target of in-page
links and stop ignoring them for purposes of accessibility.

Windows screen readers were getting confused if the object to which an in-page
link scrolled to was not an actual link target.
BUG=37721
R=dmazzoni@chromium.org
TESTED=manual testing with file attached to bug
==========

to

==========
Added a quick heuristic to determine which objects are the target of in-page
links and stop ignoring them for purposes of accessibility.

Windows screen readers were getting confused if the object to which an in-page
link scrolled to was not an actual link target.
BUG=37721
R=dmazzoni@chromium.org
TESTED=manual testing with file attached to bug
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[nektarios, 2017-03-29 22:17:43]

The CQ bit was checked by nektar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 22:18:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 23:22:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 23:22:07]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[nektarios, 2017-03-30 15:54:02]

The CQ bit was checked by nektar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 15:54:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 16:36:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 16:36:24]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[nektarios, 2017-03-30 17:32:26]

The CQ bit was checked by nektar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 17:32:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 18:08:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 18:08:16]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nektarios, 2017-03-31 14:45:28]

The CQ bit was checked by nektar@chromium.org

[nektarios, 2017-03-31 14:45:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2713193003/#ps210001
(title: "Fixed tests.")

[commit-bot: I haz the power, 2017-03-31 14:46:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 15:43:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 15:43:20]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[nektarios, 2017-03-31 16:07:57]

The CQ bit was checked by nektar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 16:08:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 18:13:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 18:13:06]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[nektarios, 2017-03-31 21:17:29]

The CQ bit was checked by nektar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 21:18:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dmazzoni, 2017-03-31 21:24:07]

lgtm

[commit-bot: I haz the power, 2017-03-31 21:54:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 21:54:29]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nektarios, 2017-03-31 22:18:21]

The CQ bit was checked by nektar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 22:19:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 23:00:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 23:00:06]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nektarios, 2017-04-02 18:45:39]

The CQ bit was checked by nektar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-02 18:45:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nektarios, 2017-04-02 18:51:23]

The CQ bit was checked by nektar@chromium.org

[nektarios, 2017-04-02 18:51:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2713193003/#ps290001
(title: "Fixed tests.")

[commit-bot: I haz the power, 2017-04-02 18:51:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-02 20:17:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-02 20:17:08]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[nektarios, 2017-04-03 15:10:00]

The CQ bit was checked by nektar@chromium.org

[nektarios, 2017-04-03 15:10:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2713193003/#ps310001
(title: "Fixed Android test.")

[commit-bot: I haz the power, 2017-04-03 15:10:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[David Tseng, 2017-04-03 17:20:17]

dtseng@chromium.org changed reviewers:
+ dtseng@chromium.org

[David Tseng, 2017-04-03 17:20:18]

https://codereview.chromium.org/2713193003/diff/310001/chrome/browser/resourc...
File
chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions_test.extjs
(right):

https://codereview.chromium.org/2713193003/diff/310001/chrome/browser/resourc...
chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions_test.extjs:105:
document.querySelectorAll('div div')[0].textContent = 'Alpha';
nit: unsure why this was changed (prvious form had ids). Seems equivalent.

https://codereview.chromium.org/2713193003/diff/310001/content/browser/access...
File content/browser/accessibility/browser_accessibility_win.cc (right):

https://codereview.chromium.org/2713193003/diff/310001/content/browser/access...
content/browser/accessibility/browser_accessibility_win.cc:5341: case
ui::AX_ROLE_ANCHOR:
Note that ChromeVox needs something like this in
chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

Specifically, add a block like
anchor: {
  speak: '$name @internal_link $state $description'
}

I can follow up with this or you can include it in this cl. Thanks!

[David Tseng, 2017-04-03 17:21:48]

https://codereview.chromium.org/2713193003/diff/310001/chrome/browser/resourc...
File
chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions_test.extjs
(right):

https://codereview.chromium.org/2713193003/diff/310001/chrome/browser/resourc...
chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions_test.extjs:105:
document.querySelectorAll('div div')[0].textContent = 'Alpha';
On 2017/04/03 17:20:18, David Tseng wrote:
> nit: unsure why this was changed (prvious form had ids). Seems equivalent.

Just read DOminic's comment on this. Please ignore.

[commit-bot: I haz the power, 2017-04-03 17:25:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 17:25:40]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[nektarios, 2017-04-03 18:47:53]

The CQ bit was checked by nektar@chromium.org

[commit-bot: I haz the power, 2017-04-03 18:49:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[blink-reviews, 2017-04-03 18:56:08]

ui::AX_ROLE_ANCHOR:
> Note that ChromeVox needs something like this in
> chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
>
> Specifically, add a block like
> anchor: {
> speak: '$name @internal_link $state $description'
> }

Since I have been trying to check this in for a few weeks now, I prefer 
to submit and then follow up with another CL including ARIA grid attributes.
Also, I think we should just ignore the role on Chromevox since it's 
only used to mark link targets, not actual links. I know that it's 
strange for link targets to be marked as having a role of link, but this 
is the only way I found for Jaws to work and I tried a few other 
combinations.
An example of an anchor is <a name="link_target><h1>Chapter one</h1></a>

Unless we add a shortcut in Chromevox to jump between same page link 
targets. Then the role might be useful. It might be a good idea.
What do you think?

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2017-04-03 18:56:08]

ui::AX_ROLE_ANCHOR:
> Note that ChromeVox needs something like this in
> chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
>
> Specifically, add a block like
> anchor: {
> speak: '$name @internal_link $state $description'
> }

Since I have been trying to check this in for a few weeks now, I prefer 
to submit and then follow up with another CL including ARIA grid attributes.
Also, I think we should just ignore the role on Chromevox since it's 
only used to mark link targets, not actual links. I know that it's 
strange for link targets to be marked as having a role of link, but this 
is the only way I found for Jaws to work and I tried a few other 
combinations.
An example of an anchor is <a name="link_target><h1>Chapter one</h1></a>

Unless we add a shortcut in Chromevox to jump between same page link 
targets. Then the role might be useful. It might be a good idea.
What do you think?

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2017-04-03 20:54:28]

CQ is committing da patch.

Bot data: {"patchset_id": 310001, "attempt_start_ts": 1491245273327820,
"parent_rev": "7f5396b89be45513d1a2f9a97c4416be04b57a2e", "commit_rev":
"9ddb2190fe84221506e9ada748bbea36f45b050d"}

[commit-bot: I haz the power, 2017-04-03 20:55:34]

Description was changed from

==========
Added a quick heuristic to determine which objects are the target of in-page
links and stop ignoring them for purposes of accessibility.

Windows screen readers were getting confused if the object to which an in-page
link scrolled to was not an actual link target.
BUG=37721
R=dmazzoni@chromium.org
TESTED=manual testing with file attached to bug
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Added a quick heuristic to determine which objects are the target of in-page
links and stop ignoring them for purposes of accessibility.

Windows screen readers were getting confused if the object to which an in-page
link scrolled to was not an actual link target.
BUG=37721
R=dmazzoni@chromium.org
TESTED=manual testing with file attached to bug
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2713193003
Cr-Commit-Position: refs/heads/master@{#461530}
Committed:
https://chromium.googlesource.com/chromium/src/+/9ddb2190fe84221506e9ada748bb...
==========

[commit-bot: I haz the power, 2017-04-03 20:55:35]

Committed patchset #17 (id:310001) as
https://chromium.googlesource.com/chromium/src/+/9ddb2190fe84221506e9ada748bb...