Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4628)

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions_test.extjs

Issue 2713193003: Added a quick heuristic to determine which objects are the target of in-page links and stop ignorin… (Closed)
Patch Set: Fixed Android test. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions_test.extjs
diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions_test.extjs b/chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions_test.extjs
index 8673a2fe6f5a89688bf05d5d1269080f56df6913..5b6e5f2d9c62b4875d5148ecaa629dfcc983127e 100644
--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions_test.extjs
+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions_test.extjs
@@ -96,13 +96,13 @@ TEST_F('LiveRegionsTest', 'LiveRegionChangeAtomic', function() {
this.runWithLoadedTree(
function() {/*!
<div id="live" aria-live="polite" aria-atomic="true">
- <div id="a"></div><div id="b">Bravo</div><div id="c"></div>
+ <div></div><div>Bravo</div><div></div>
</div>
<button id="go">Go</button>
<script>
document.getElementById('go').addEventListener('click', function() {
- document.getElementById('c').textContent = 'Charlie';
- document.getElementById('a').textContent = 'Alpha';
+ document.querySelectorAll('div div')[2].textContent = 'Charlie';
+ document.querySelectorAll('div div')[0].textContent = 'Alpha';
David Tseng 2017/04/03 17:20:18 nit: unsure why this was changed (prvious form had
David Tseng 2017/04/03 17:21:48 Just read DOminic's comment on this. Please ignore
}, false);
</script>
*/},
« no previous file with comments | « no previous file | chrome/common/extensions/api/automation.idl » ('j') | content/browser/accessibility/browser_accessibility_win.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698