Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Side by Side Diff: third_party/WebKit/Source/modules/accessibility/AXObject.cpp

Issue 2713193003: Added a quick heuristic to determine which objects are the target of in-page links and stop ignorin… (Closed)
Patch Set: Fixed Android test. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2009, 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2008, 2009, 2011 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 struct InternalRoleEntry { 135 struct InternalRoleEntry {
136 AccessibilityRole webcoreRole; 136 AccessibilityRole webcoreRole;
137 const char* internalRoleName; 137 const char* internalRoleName;
138 }; 138 };
139 139
140 const InternalRoleEntry internalRoles[] = { 140 const InternalRoleEntry internalRoles[] = {
141 {UnknownRole, "Unknown"}, 141 {UnknownRole, "Unknown"},
142 {AbbrRole, "Abbr"}, 142 {AbbrRole, "Abbr"},
143 {AlertDialogRole, "AlertDialog"}, 143 {AlertDialogRole, "AlertDialog"},
144 {AlertRole, "Alert"}, 144 {AlertRole, "Alert"},
145 {AnchorRole, "Anchor"},
145 {AnnotationRole, "Annotation"}, 146 {AnnotationRole, "Annotation"},
146 {ApplicationRole, "Application"}, 147 {ApplicationRole, "Application"},
147 {ArticleRole, "Article"}, 148 {ArticleRole, "Article"},
148 {AudioRole, "Audio"}, 149 {AudioRole, "Audio"},
149 {BannerRole, "Banner"}, 150 {BannerRole, "Banner"},
150 {BlockquoteRole, "Blockquote"}, 151 {BlockquoteRole, "Blockquote"},
151 // TODO(nektar): Delete busy_indicator role. It's used nowhere. 152 // TODO(nektar): Delete busy_indicator role. It's used nowhere.
152 {BusyIndicatorRole, "BusyIndicator"}, 153 {BusyIndicatorRole, "BusyIndicator"},
153 {ButtonRole, "Button"}, 154 {ButtonRole, "Button"},
154 {CanvasRole, "Canvas"}, 155 {CanvasRole, "Canvas"},
(...skipping 1557 matching lines...) Expand 10 before | Expand all | Expand 10 after
1712 role.split(' ', roleVector); 1713 role.split(' ', roleVector);
1713 for (const auto& child : roleVector) { 1714 for (const auto& child : roleVector) {
1714 if (roleSet->contains(child)) 1715 if (roleSet->contains(child))
1715 return true; 1716 return true;
1716 } 1717 }
1717 return false; 1718 return false;
1718 } 1719 }
1719 1720
1720 bool AXObject::nameFromContents() const { 1721 bool AXObject::nameFromContents() const {
1721 switch (roleValue()) { 1722 switch (roleValue()) {
1723 case AnchorRole:
1722 case ButtonRole: 1724 case ButtonRole:
1723 case CheckBoxRole: 1725 case CheckBoxRole:
1724 case DirectoryRole: 1726 case DirectoryRole:
1725 case DisclosureTriangleRole: 1727 case DisclosureTriangleRole:
1726 case HeadingRole: 1728 case HeadingRole:
1727 case LineBreakRole: 1729 case LineBreakRole:
1728 case LinkRole: 1730 case LinkRole:
1729 case ListBoxOptionRole: 1731 case ListBoxOptionRole:
1730 case ListItemRole: 1732 case ListItemRole:
1731 case MenuItemRole: 1733 case MenuItemRole:
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
1773 } 1775 }
1774 1776
1775 DEFINE_TRACE(AXObject) { 1777 DEFINE_TRACE(AXObject) {
1776 visitor->trace(m_children); 1778 visitor->trace(m_children);
1777 visitor->trace(m_parent); 1779 visitor->trace(m_parent);
1778 visitor->trace(m_cachedLiveRegionRoot); 1780 visitor->trace(m_cachedLiveRegionRoot);
1779 visitor->trace(m_axObjectCache); 1781 visitor->trace(m_axObjectCache);
1780 } 1782 }
1781 1783
1782 } // namespace blink 1784 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698