Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(937)

Unified Diff: third_party/WebKit/LayoutTests/accessibility/in-page-link-target.html

Issue 2713193003: Added a quick heuristic to determine which objects are the target of in-page links and stop ignorin… (Closed)
Patch Set: Fixed Android test. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/accessibility/in-page-link-target.html
diff --git a/third_party/WebKit/LayoutTests/accessibility/in-page-link-target.html b/third_party/WebKit/LayoutTests/accessibility/in-page-link-target.html
index 387798ae76b072efc320c042faa14a51d53ddc65..68cf85187f9f4b332761041b6542331268fe10a0 100644
--- a/third_party/WebKit/LayoutTests/accessibility/in-page-link-target.html
+++ b/third_party/WebKit/LayoutTests/accessibility/in-page-link-target.html
@@ -24,8 +24,10 @@ test(function() {
assert_not_equals(anchor, undefined);
var target = anchor.inPageLinkTarget;
assert_not_equals(target, undefined);
- assert_equals(target.role, 'AXRole: AXStaticText');
- assert_equals(target.name, 'After empty anchor');
+ // AXAncor because this is how the "a" tag is marked in the accessibility tree
+ // when it's a target and not a link.
+ assert_equals(target.role, 'AXRole: AXAnchor');
+ assert_equals(target.name, '');
}, 'Test finding the target when it is an empty anchor.');
test(function() {
@@ -33,9 +35,9 @@ test(function() {
assert_not_equals(anchor, undefined);
var target = anchor.inPageLinkTarget;
assert_not_equals(target, undefined);
- // AXStaticText because this is how the "a" tag is marked in the accessibility
- // tree when it's a target and not a link.
- assert_equals(target.role, 'AXRole: AXStaticText');
+ // AXAncor because this is how the "a" tag is marked in the accessibility tree
+ // when it's a target and not a link.
+ assert_equals(target.role, 'AXRole: AXAnchor');
assert_equals(target.name, 'Anchor with content');
}, 'Test finding the target when it is an anchor with content.');
@@ -44,9 +46,9 @@ test(function() {
assert_not_equals(anchor, undefined);
var target = anchor.inPageLinkTarget;
assert_not_equals(target, undefined);
- // AXStaticText because this is how the "a" tag is marked in the accessibility
- // tree when it's a target and not a link.
- assert_equals(target.role, 'AXRole: AXStaticText');
+ // AXAncor because this is how the "a" tag is marked in the accessibility tree
+ // when it's a target and not a link.
+ assert_equals(target.role, 'AXRole: AXAnchor');
assert_equals(target.name, 'Anchor with ID');
}, 'Test finding the target when it is an anchor with ID.');

Powered by Google App Engine
This is Rietveld 408576698