third_party/WebKit/Source/modules/accessibility/AXObject.cpp - Issue 2713193003: Added a quick heuristic to determine which objects are the target of in-page links and stop ignorin…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXObject.cpp

Issue 2713193003: Added a quick heuristic to determine which objects are the target of in-page links and stop ignorin… (Closed)

Patch Set: Fixed Android test. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/accessibility/AXObject.cpp

diff --git a/third_party/WebKit/Source/modules/accessibility/AXObject.cpp b/third_party/WebKit/Source/modules/accessibility/AXObject.cpp

index 1671402dcd5fb2400ead7a92e9c4bf9a26b00e83..44c89bf2398c4a09ce46638b42e2746fc71473a0 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXObject.cpp

+++ b/third_party/WebKit/Source/modules/accessibility/AXObject.cpp

@@ -142,6 +142,7 @@ const InternalRoleEntry internalRoles[] = {

{AbbrRole, "Abbr"},

{AlertDialogRole, "AlertDialog"},

{AlertRole, "Alert"},

+ {AnchorRole, "Anchor"},

{AnnotationRole, "Annotation"},

{ApplicationRole, "Application"},

{ArticleRole, "Article"},

@@ -1719,6 +1720,7 @@ bool AXObject::includesARIAWidgetRole(const String& role) {

bool AXObject::nameFromContents() const {

switch (roleValue()) {

+ case AnchorRole:

case ButtonRole:

case CheckBoxRole:

case DirectoryRole: