Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

Issue 2713193003: Added a quick heuristic to determine which objects are the target of in-page links and stop ignorin… (Closed)
Patch Set: Fixed Android test. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
diff --git a/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp b/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
index 73359759e1a26dc3c8f0988ada36871bbd1cb017..c628d6e0f000c4eb5b238dedb91035c238c8d252 100644
--- a/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
+++ b/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
@@ -589,6 +589,12 @@ bool AXLayoutObject::computeAccessibilityIsIgnored(
if (m_layoutObject->isBR())
return false;
+ if (isLink())
+ return false;
+
+ if (isInPageLinkTarget())
+ return false;
+
if (m_layoutObject->isText()) {
// Static text beneath MenuItems and MenuButtons are just reported along
// with the menu item, so it's ignored on an individual level.
@@ -637,9 +643,6 @@ bool AXLayoutObject::computeAccessibilityIsIgnored(
(getNode()->hasTagName(headerTag) || getNode()->hasTagName(footerTag)))
return false;
- if (isLink())
- return false;
-
// all controls are accessible
if (isControl())
return false;

Powered by Google App Engine
This is Rietveld 408576698