Added a quick heuristic to determine which objects are the target of in-page links and stop ignorin…

third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp

 /*
  * Copyright (C) 2012, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 22 matching lines @@
 #include "core/dom/Element.h"
 #include "core/dom/NodeTraversal.h"
 #include "core/dom/QualifiedName.h"
 #include "core/dom/Text.h"
 #include "core/dom/shadow/FlatTreeTraversal.h"
 #include "core/editing/EditingUtilities.h"
 #include "core/editing/markers/DocumentMarkerController.h"
 #include "core/frame/FrameView.h"
 #include "core/html/HTMLAnchorElement.h"
 #include "core/html/HTMLDListElement.h"
+#include "core/html/HTMLDivElement.h"
 #include "core/html/HTMLFieldSetElement.h"
 #include "core/html/HTMLFrameElementBase.h"
 #include "core/html/HTMLImageElement.h"
 #include "core/html/HTMLInputElement.h"
 #include "core/html/HTMLLabelElement.h"
 #include "core/html/HTMLLegendElement.h"
 #include "core/html/HTMLMediaElement.h"
 #include "core/html/HTMLMeterElement.h"
 #include "core/html/HTMLPlugInElement.h"
 #include "core/html/HTMLSelectElement.h"
@@ skipping 401 matching lines @@
     if (tagNames.contains(parent->tagQName()))
       return true;
   }
   return false;
 }
 
 AccessibilityRole AXNodeObject::nativeAccessibilityRoleIgnoringAria() const {
   if (!getNode())
     return UnknownRole;
 
-  // HTMLAnchorElement sets isLink only when it has hrefAttr.
-  // We assume that it is also LinkRole if it has event listners even though it
-  // doesn't have hrefAttr.
-  if (getNode()->isLink() || (isHTMLAnchorElement(*getNode()) && isClickable()))
+  // |HTMLAnchorElement| sets isLink only when it has hrefAttr.
+  if (getNode()->isLink())
     return LinkRole;
 
+  if (isHTMLAnchorElement(*getNode())) {
+    // We assume that an anchor element is LinkRole if it has event listners
+    // even though it doesn't have hrefAttr.
+    if (isClickable())
+      return LinkRole;
+    return AnchorRole;
+  }
+
   if (isHTMLButtonElement(*getNode()))
     return buttonRoleType();
 
   if (isHTMLDetailsElement(*getNode()))
     return DetailsRole;
 
   if (isHTMLSummaryElement(*getNode())) {
     ContainerNode* parent = FlatTreeTraversal::parent(*getNode());
     if (parent && isHTMLDetailsElement(parent))
       return DisclosureTriangleRole;
@@ skipping 173 matching lines @@
 
   if (getNode()->nodeName() == "TIME")
     return TimeRole;
 
   if (isEmbeddedObject())
     return EmbeddedObjectRole;
 
   if (isHTMLHRElement(*getNode()))
     return SplitterRole;
 
-  if (isFieldset()) {
+  if (isFieldset())
     return GroupRole;
-  }
 
   return UnknownRole;
 }
 
 AccessibilityRole AXNodeObject::determineAccessibilityRole() {
   if (!getNode())
     return UnknownRole;
 
   if ((m_ariaRole = determineAriaRoleAttribute()) != UnknownRole)
     return m_ariaRole;
@@ skipping 297 matching lines @@
   if (roleValue() == ButtonRole && isHTMLInputElement(node))
     return toHTMLInputElement(*node).type() == InputTypeNames::image;
 
   return false;
 }
 
 bool AXNodeObject::isLink() const {
   return roleValue() == LinkRole;
 }
 
+// It is not easily possible to find out if an element is the target of an
+// in-page link.
+// As a workaround, we check if the element is a sectioning element with an ID,
+// or an anchor with a name.
+bool AXNodeObject::isInPageLinkTarget() const {
+  if (!m_node || !m_node->isElementNode())
+    return false;
+  Element* element = toElement(m_node);
+  // We exclude elements that are in the shadow DOM.
+  if (element->containingShadowRoot())
+    return false;
+
+  if (isHTMLAnchorElement(element)) {
+    HTMLAnchorElement* htmlElement = toHTMLAnchorElement(element);
+    return htmlElement->hasName() || htmlElement->hasID();
+  }
+
+  if (element->hasID() && (isLandmarkRelated() || isHTMLDivElement(element)))
+    return true;
+  return false;
+}
+
 bool AXNodeObject::isMenu() const {
   return roleValue() == MenuRole;
 }
 
 bool AXNodeObject::isMenuButton() const {
   return roleValue() == MenuButtonRole;
 }
 
 bool AXNodeObject::isMeter() const {
   return roleValue() == MeterRole;
@@ skipping 2213 matching lines @@
     return String();
   return toTextControlElement(node)->strippedPlaceholder();
 }
 
 DEFINE_TRACE(AXNodeObject) {
   visitor->trace(m_node);
   AXObject::trace(visitor);
 }
 
 }  // namespace blink