Clear opener when frame is detached.

Clear opener when frame is detached.

This is important in order to avoid exposing detached WebFrames through the blink public API.

BUG=691012
Review-Url: https://codereview.chromium.org/2706963004
Cr-Commit-Position: refs/heads/master@{#452079}
Committed: https://chromium.googlesource.com/chromium/src/+/ba0384c082b837cc801e56290998caee0d2f145b

[lfg, 2017-02-21 21:50:25]

The CQ bit was checked by lfg@chromium.org to run a CQ dry run

[lfg, 2017-02-21 21:52:14]

lfg@chromium.org changed reviewers:
+ dcheng@chromium.org

[lfg, 2017-02-21 21:52:14]

Daniel, please take a look.

[commit-bot: I haz the power, 2017-02-21 21:52:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2017-02-21 21:59:37]

https://codereview.chromium.org/2706963004/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/OpenedFrameTracker.cpp (right):

https://codereview.chromium.org/2706963004/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/OpenedFrameTracker.cpp:14:
OpenedFrameTracker::~OpenedFrameTracker() {}
DCHECK(m_openedFrames.isEmpty())

https://codereview.chromium.org/2706963004/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/OpenedFrameTracker.h (right):

https://codereview.chromium.org/2706963004/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/OpenedFrameTracker.h:34: void detach() {
transferTo(nullptr); }
Nit: call this dispose().

[lfg, 2017-02-21 22:04:31]

The CQ bit was checked by lfg@chromium.org to run a CQ dry run

[lfg, 2017-02-21 22:04:50]

https://codereview.chromium.org/2706963004/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/OpenedFrameTracker.cpp (right):

https://codereview.chromium.org/2706963004/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/OpenedFrameTracker.cpp:14:
OpenedFrameTracker::~OpenedFrameTracker() {}
On 2017/02/21 21:59:37, dcheng wrote:
> DCHECK(m_openedFrames.isEmpty())

Done.

https://codereview.chromium.org/2706963004/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/OpenedFrameTracker.h (right):

https://codereview.chromium.org/2706963004/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/OpenedFrameTracker.h:34: void detach() {
transferTo(nullptr); }
On 2017/02/21 21:59:37, dcheng wrote:
> Nit: call this dispose().

Done.

[commit-bot: I haz the power, 2017-02-21 22:05:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2017-02-21 22:09:07]

LGTM

Please expand the CL description to document why we need to do this (it's
important to avoid exposing partially detached WebFrames through the Blink
public API; otherwise, it's easy for the embedder to try to use a WebFrame that
no longer has a core Frame, resulting in crashes, etc.), since it's somewhat
subtle.

+haraken, +sigbjornf as fyi

[dcheng, 2017-02-21 22:09:31]

On 2017/02/21 22:09:07, dcheng wrote:
> LGTM
> 
> Please expand the CL description to document why we need to do this (it's
> important to avoid exposing partially detached WebFrames through the Blink
> public API; otherwise, it's easy for the embedder to try to use a WebFrame
that
> no longer has a core Frame, resulting in crashes, etc.), since it's somewhat
> subtle.
> 
> +haraken, +sigbjornf as fyi

(Minor clarification: I guess it's not really partially detached, it's just
detached =)

[commit-bot: I haz the power, 2017-02-22 00:07:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 00:07:58]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[haraken, 2017-02-22 00:25:43]

LGTM

[lfg, 2017-02-22 15:13:49]

Description was changed from

==========
Clear opener when frame is detached.

BUG=691012
==========

to

==========
Clear opener when frame is detached.

This is important in order to avoid exposing detached WebFrames through the
blink public API.

BUG=691012
==========

[lfg, 2017-02-22 15:14:49]

The CQ bit was checked by lfg@chromium.org

[commit-bot: I haz the power, 2017-02-22 15:15:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 16:30:29]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487776489921400,
"parent_rev": "67a1b1710007ab1625627f07139517a3d191c05a", "commit_rev":
"ba0384c082b837cc801e56290998caee0d2f145b"}

[commit-bot: I haz the power, 2017-02-22 16:31:05]

Description was changed from

==========
Clear opener when frame is detached.

This is important in order to avoid exposing detached WebFrames through the
blink public API.

BUG=691012
==========

to

==========
Clear opener when frame is detached.

This is important in order to avoid exposing detached WebFrames through the
blink public API.

BUG=691012

Review-Url: https://codereview.chromium.org/2706963004
Cr-Commit-Position: refs/heads/master@{#452079}
Committed:
https://chromium.googlesource.com/chromium/src/+/ba0384c082b837cc801e56290998...
==========

[commit-bot: I haz the power, 2017-02-22 16:31:06]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ba0384c082b837cc801e56290998...