Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1045)

Unified Diff: third_party/WebKit/Source/web/OpenedFrameTracker.cpp

Issue 2706963004: Clear opener when frame is detached. (Closed)
Patch Set: addressing comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/OpenedFrameTracker.h ('k') | third_party/WebKit/Source/web/WebFrame.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/OpenedFrameTracker.cpp
diff --git a/third_party/WebKit/Source/web/OpenedFrameTracker.cpp b/third_party/WebKit/Source/web/OpenedFrameTracker.cpp
index cc96b6440528143a05845bd3935c15318213a4e7..30c44ba10f4b1901cbd9304e3ea202308faaa763 100644
--- a/third_party/WebKit/Source/web/OpenedFrameTracker.cpp
+++ b/third_party/WebKit/Source/web/OpenedFrameTracker.cpp
@@ -11,7 +11,9 @@ namespace blink {
OpenedFrameTracker::OpenedFrameTracker() {}
-OpenedFrameTracker::~OpenedFrameTracker() {}
+OpenedFrameTracker::~OpenedFrameTracker() {
+ DCHECK(isEmpty());
+}
bool OpenedFrameTracker::isEmpty() const {
return m_openedFrames.isEmpty();
@@ -33,9 +35,4 @@ void OpenedFrameTracker::transferTo(WebFrame* opener) {
frame->setOpener(opener);
}
-void OpenedFrameTracker::traceFrames(Visitor* visitor) {
- for (WebFrame* frame : m_openedFrames)
- WebFrame::traceFrame(visitor, frame);
-}
-
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/web/OpenedFrameTracker.h ('k') | third_party/WebKit/Source/web/WebFrame.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698