Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Side by Side Diff: third_party/WebKit/Source/web/OpenedFrameTracker.cpp

Issue 2706963004: Clear opener when frame is detached. (Closed)
Patch Set: addressing comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "web/OpenedFrameTracker.h" 5 #include "web/OpenedFrameTracker.h"
6 6
7 #include "platform/heap/Handle.h" 7 #include "platform/heap/Handle.h"
8 #include "public/web/WebFrame.h" 8 #include "public/web/WebFrame.h"
9 9
10 namespace blink { 10 namespace blink {
11 11
12 OpenedFrameTracker::OpenedFrameTracker() {} 12 OpenedFrameTracker::OpenedFrameTracker() {}
13 13
14 OpenedFrameTracker::~OpenedFrameTracker() {} 14 OpenedFrameTracker::~OpenedFrameTracker() {
15 DCHECK(isEmpty());
16 }
15 17
16 bool OpenedFrameTracker::isEmpty() const { 18 bool OpenedFrameTracker::isEmpty() const {
17 return m_openedFrames.isEmpty(); 19 return m_openedFrames.isEmpty();
18 } 20 }
19 21
20 void OpenedFrameTracker::add(WebFrame* frame) { 22 void OpenedFrameTracker::add(WebFrame* frame) {
21 m_openedFrames.insert(frame); 23 m_openedFrames.insert(frame);
22 } 24 }
23 25
24 void OpenedFrameTracker::remove(WebFrame* frame) { 26 void OpenedFrameTracker::remove(WebFrame* frame) {
25 m_openedFrames.erase(frame); 27 m_openedFrames.erase(frame);
26 } 28 }
27 29
28 void OpenedFrameTracker::transferTo(WebFrame* opener) { 30 void OpenedFrameTracker::transferTo(WebFrame* opener) {
29 // Copy the set of opened frames, since changing the owner will mutate this 31 // Copy the set of opened frames, since changing the owner will mutate this
30 // set. 32 // set.
31 HashSet<WebFrame*> frames(m_openedFrames); 33 HashSet<WebFrame*> frames(m_openedFrames);
32 for (WebFrame* frame : frames) 34 for (WebFrame* frame : frames)
33 frame->setOpener(opener); 35 frame->setOpener(opener);
34 } 36 }
35 37
36 void OpenedFrameTracker::traceFrames(Visitor* visitor) {
37 for (WebFrame* frame : m_openedFrames)
38 WebFrame::traceFrame(visitor, frame);
39 }
40
41 } // namespace blink 38 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/OpenedFrameTracker.h ('k') | third_party/WebKit/Source/web/WebFrame.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698