Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1071)

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 2706963004: Clear opener when frame is detached. (Closed)
Patch Set: addressing comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebFrame.cpp ('k') | third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
index 89d55678ff7d6f26ed137803c28d2265c307216c..ecc46846fb43d824cc7afebc4be673cf2ff3ff28 100644
--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
@@ -532,6 +532,8 @@ WebRemoteFrame* WebLocalFrameImpl::toWebRemoteFrame() {
}
void WebLocalFrameImpl::close() {
+ WebLocalFrame::close();
+
m_client = nullptr;
if (m_devToolsAgent)
@@ -1561,8 +1563,6 @@ DEFINE_TRACE(WebLocalFrameImpl) {
visitor->trace(m_textFinder);
visitor->trace(m_printContext);
visitor->trace(m_contextMenuNode);
- visitor->template registerWeakMembers<WebFrame, &WebFrame::clearWeakFrames>(
- this);
WebFrame::traceFrames(visitor, this);
WebFrameImplBase::trace(visitor);
}
« no previous file with comments | « third_party/WebKit/Source/web/WebFrame.cpp ('k') | third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698