Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

Issue 2706963004: Clear opener when frame is detached. (Closed)
Patch Set: addressing comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp b/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp
index 3cb385991a22641af04526cd8fc0445b91c6569b..2c6742240c54b1518aea05e27d2303d1b04c41cc 100644
--- a/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp
+++ b/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp
@@ -47,8 +47,6 @@ WebRemoteFrameImpl::~WebRemoteFrameImpl() {}
DEFINE_TRACE(WebRemoteFrameImpl) {
visitor->trace(m_frameClient);
visitor->trace(m_frame);
- visitor->template registerWeakMembers<WebFrame, &WebFrame::clearWeakFrames>(
- this);
WebFrame::traceFrames(visitor, this);
WebFrameImplBase::trace(visitor);
}
@@ -71,6 +69,8 @@ WebRemoteFrame* WebRemoteFrameImpl::toWebRemoteFrame() {
}
void WebRemoteFrameImpl::close() {
+ WebRemoteFrame::close();
+
m_selfKeepAlive.clear();
}
« no previous file with comments | « third_party/WebKit/Source/web/WebLocalFrameImpl.cpp ('k') | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698