Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 2706963004: Clear opener when frame is detached. (Closed)
Patch Set: addressing comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp ('k') | third_party/WebKit/public/web/WebFrame.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
index 5cf3d886c2f2063ea69db0be24a73080cc397bad..7c1a88f1b0d42df43a2d01da0d40de57f714d36c 100644
--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
@@ -11401,4 +11401,15 @@ TEST_F(WebFrameTest, NoLoadingCompletionCallbacksInDetach) {
webViewHelper.reset();
}
+TEST_F(WebFrameTest, ClearClosedOpener) {
+ FrameTestHelpers::TestWebViewClient openerWebViewClient;
+ FrameTestHelpers::WebViewHelper openerHelper;
+ openerHelper.initialize(false, nullptr, &openerWebViewClient);
+ FrameTestHelpers::WebViewHelper helper;
+ helper.initializeWithOpener(openerHelper.webView()->mainFrame());
+
+ openerHelper.reset();
+ EXPECT_EQ(nullptr, helper.webView()->mainFrameImpl()->opener());
+}
+
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp ('k') | third_party/WebKit/public/web/WebFrame.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698