Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 2706963004: Clear opener when frame is detached. (Closed)
Patch Set: addressing comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 11383 matching lines...) Expand 10 before | Expand all | Expand 10 after
11394 &mainFrameClient); 11394 &mainFrameClient);
11395 11395
11396 EXPECT_TRUE(mainFrameClient.childClient().didCallFrameDetached()); 11396 EXPECT_TRUE(mainFrameClient.childClient().didCallFrameDetached());
11397 EXPECT_TRUE(mainFrameClient.childClient().didCallDidStopLoading()); 11397 EXPECT_TRUE(mainFrameClient.childClient().didCallDidStopLoading());
11398 EXPECT_TRUE(mainFrameClient.childClient().didCallDidFinishDocumentLoad()); 11398 EXPECT_TRUE(mainFrameClient.childClient().didCallDidFinishDocumentLoad());
11399 EXPECT_TRUE(mainFrameClient.childClient().didCallDidHandleOnloadEvents()); 11399 EXPECT_TRUE(mainFrameClient.childClient().didCallDidHandleOnloadEvents());
11400 11400
11401 webViewHelper.reset(); 11401 webViewHelper.reset();
11402 } 11402 }
11403 11403
11404 TEST_F(WebFrameTest, ClearClosedOpener) {
11405 FrameTestHelpers::TestWebViewClient openerWebViewClient;
11406 FrameTestHelpers::WebViewHelper openerHelper;
11407 openerHelper.initialize(false, nullptr, &openerWebViewClient);
11408 FrameTestHelpers::WebViewHelper helper;
11409 helper.initializeWithOpener(openerHelper.webView()->mainFrame());
11410
11411 openerHelper.reset();
11412 EXPECT_EQ(nullptr, helper.webView()->mainFrameImpl()->opener());
11413 }
11414
11404 } // namespace blink 11415 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp ('k') | third_party/WebKit/public/web/WebFrame.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698