Replace WmWindowObserver with aura::WindowObserver.

Replace WmWindowObserver with aura::WindowObserver.

Also, some cleanup, mostly around ShelfWindowWatcher:
-Convert most ShelfWindowWatcher WmWindow use to aura::Window.
-Use aura::client::ActivationChangeObserver in ShelfWindowWatcher.
-Persist mash default shelf item type (app) workaround from WmWindow.

BUG=687654
TEST=No behavior changes
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2699033002
Cr-Commit-Position: refs/heads/master@{#451467}
Committed: https://chromium.googlesource.com/chromium/src/+/13fbda637196d8a45059840cfd285cd7c3d85124

[msw, 2017-02-17 21:22:46]

Description was changed from

==========
Replace WmWindowObserver with aura::WindowObserver.

BUG=687654
==========

to

==========
Replace WmWindowObserver with aura::WindowObserver.

ABANDONED, I SPLIT THIS UP INTO:
*Convert AshDevToolsDOMAgent to aura::WindowObserver
codereview.chromium.org/2700103005 
*Convert some WmWindowObservers to aura::WindowObserver
codereview.chromium.org/2707513002 
*Convert VideoDetector to aura::WindowObserver
codereview.chromium.org/2702443004 
*Convert MaximizeModeWindowManager to aura::WindowObserver
codereview.chromium.org/2700863003 
*Convert ShelfWindowWatcher to aura::WindowObserver
codereview.chromium.org/2705693002 
*Remove WmWindowObserver and final references codereview.chromium.org/2704693003


BUG=687654
==========

[msw, 2017-02-17 23:04:30]

Description was changed from

==========
Replace WmWindowObserver with aura::WindowObserver.

ABANDONED, I SPLIT THIS UP INTO:
*Convert AshDevToolsDOMAgent to aura::WindowObserver
codereview.chromium.org/2700103005 
*Convert some WmWindowObservers to aura::WindowObserver
codereview.chromium.org/2707513002 
*Convert VideoDetector to aura::WindowObserver
codereview.chromium.org/2702443004 
*Convert MaximizeModeWindowManager to aura::WindowObserver
codereview.chromium.org/2700863003 
*Convert ShelfWindowWatcher to aura::WindowObserver
codereview.chromium.org/2705693002 
*Remove WmWindowObserver and final references codereview.chromium.org/2704693003


BUG=687654
==========

to

==========
Replace WmWindowObserver with aura::WindowObserver.

BUG=687654
==========

[msw, 2017-02-17 23:10:17]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 23:11:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2017-02-17 23:12:53]

Description was changed from

==========
Replace WmWindowObserver with aura::WindowObserver.

BUG=687654
==========

to

==========
Replace WmWindowObserver with aura::WindowObserver.

Also, some cleanup, mostly around ShelfWindowWatcher:
-Convert most ShelfWindowWatcher WmWindow use to aura::Window.
-Use aura::client::ActivationChangeObserver in ShelfWindowWatcher.
-Persist mash default shelf item type (app) workaround from WmWindow.

BUG=687654
TEST=No behavior changes
R=sky@chromium.org
==========

[msw, 2017-02-17 23:12:54]

msw@chromium.org changed reviewers:
+ sky@chromium.org

[msw, 2017-02-17 23:13:14]

Hey Scott, please take a look; thanks!

[sky, 2017-02-17 23:37:59]

Nice! LGTM

[commit-bot: I haz the power, 2017-02-18 01:15:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 01:15:25]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[msw, 2017-02-18 01:37:36]

The CQ bit was checked by msw@chromium.org

[msw, 2017-02-18 01:37:36]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2699033002/#ps60001
(title: "Check for null images in ShelfWindowWatcher.")

[commit-bot: I haz the power, 2017-02-18 01:38:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 03:41:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 03:41:02]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[msw, 2017-02-18 16:55:17]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2017-02-18 16:55:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 17:00:25]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487436917471590,
"parent_rev": "98a1e01f4f58d073314620488e4563bb1cfee39d", "commit_rev":
"13fbda637196d8a45059840cfd285cd7c3d85124"}

[commit-bot: I haz the power, 2017-02-18 17:01:04]

Description was changed from

==========
Replace WmWindowObserver with aura::WindowObserver.

Also, some cleanup, mostly around ShelfWindowWatcher:
-Convert most ShelfWindowWatcher WmWindow use to aura::Window.
-Use aura::client::ActivationChangeObserver in ShelfWindowWatcher.
-Persist mash default shelf item type (app) workaround from WmWindow.

BUG=687654
TEST=No behavior changes
R=sky@chromium.org
==========

to

==========
Replace WmWindowObserver with aura::WindowObserver.

Also, some cleanup, mostly around ShelfWindowWatcher:
-Convert most ShelfWindowWatcher WmWindow use to aura::Window.
-Use aura::client::ActivationChangeObserver in ShelfWindowWatcher.
-Persist mash default shelf item type (app) workaround from WmWindow.

BUG=687654
TEST=No behavior changes
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2699033002
Cr-Commit-Position: refs/heads/master@{#451467}
Committed:
https://chromium.googlesource.com/chromium/src/+/13fbda637196d8a45059840cfd28...
==========

[commit-bot: I haz the power, 2017-02-18 17:01:05]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/13fbda637196d8a45059840cfd28...