Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: ash/common/wm_window_user_data.h

Issue 2699033002: Replace WmWindowObserver with aura::WindowObserver. (Closed)
Patch Set: Check for null images in ShelfWindowWatcher. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ash/common/wm_window_unittest.cc ('k') | ash/display/screen_orientation_controller_chromeos.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ASH_COMMON_WM_WINDOW_USER_DATA_H_ 5 #ifndef ASH_COMMON_WM_WINDOW_USER_DATA_H_
6 #define ASH_COMMON_WM_WINDOW_USER_DATA_H_ 6 #define ASH_COMMON_WM_WINDOW_USER_DATA_H_
7 7
8 #include <map> 8 #include <map>
9 #include <memory> 9 #include <memory>
10 #include <utility> 10 #include <utility>
11 11
12 #include "ash/common/wm_window.h" 12 #include "ash/common/wm_window.h"
13 #include "ash/common/wm_window_observer.h"
14 #include "base/macros.h" 13 #include "base/macros.h"
14 #include "ui/aura/window.h"
15 #include "ui/aura/window_observer.h"
15 16
16 namespace ash { 17 namespace ash {
17 18
18 // WmWindowUserData provides a way to associate arbitrary objects with a 19 // WmWindowUserData provides a way to associate arbitrary objects with a
19 // WmWindow. WmWindowUserData owns the data, deleting it either when 20 // WmWindow. WmWindowUserData owns the data, deleting it either when
20 // WmWindowUserData is deleted, or when the window the data is associated with 21 // WmWindowUserData is deleted, or when the window the data is associated with
21 // is destroyed (from WmWindowObserver::OnWindowDestroying()). 22 // is destroyed (from aura::WindowObserver::OnWindowDestroying()).
22 template <typename UserData> 23 template <typename UserData>
23 class WmWindowUserData : public WmWindowObserver { 24 class WmWindowUserData : public aura::WindowObserver {
24 public: 25 public:
25 WmWindowUserData() {} 26 WmWindowUserData() {}
26 27
27 ~WmWindowUserData() override { clear(); } 28 ~WmWindowUserData() override { clear(); }
28 29
29 void clear() { 30 void clear() {
30 for (auto& pair : window_to_data_) 31 for (auto& pair : window_to_data_)
31 pair.first->RemoveObserver(this); 32 pair.first->aura_window()->RemoveObserver(this);
32 window_to_data_.clear(); 33 window_to_data_.clear();
33 } 34 }
34 35
35 // Sets the data associated with window. This destroys any existing data. 36 // Sets the data associated with window. This destroys any existing data.
36 // |data| may be null. 37 // |data| may be null.
37 void Set(WmWindow* window, std::unique_ptr<UserData> data) { 38 void Set(WmWindow* window, std::unique_ptr<UserData> data) {
38 if (!data) { 39 if (!data) {
39 if (window_to_data_.erase(window)) 40 if (window_to_data_.erase(window))
40 window->RemoveObserver(this); 41 window->aura_window()->RemoveObserver(this);
41 return; 42 return;
42 } 43 }
43 if (window_to_data_.count(window) == 0u) 44 if (window_to_data_.count(window) == 0u)
44 window->AddObserver(this); 45 window->aura_window()->AddObserver(this);
45 window_to_data_[window] = std::move(data); 46 window_to_data_[window] = std::move(data);
46 } 47 }
47 48
48 // Returns the data associated with the window, or null if none set. The 49 // Returns the data associated with the window, or null if none set. The
49 // returned object is owned by WmWindowUserData. 50 // returned object is owned by WmWindowUserData.
50 UserData* Get(WmWindow* window) { 51 UserData* Get(WmWindow* window) {
51 auto it = window_to_data_.find(window); 52 auto it = window_to_data_.find(window);
52 return it == window_to_data_.end() ? nullptr : it->second.get(); 53 return it == window_to_data_.end() ? nullptr : it->second.get();
53 } 54 }
54 55
55 // Returns the set of windows with data associated with them. 56 // Returns the set of windows with data associated with them.
56 std::set<WmWindow*> GetWindows() { 57 std::set<WmWindow*> GetWindows() {
57 std::set<WmWindow*> windows; 58 std::set<WmWindow*> windows;
58 for (auto& pair : window_to_data_) 59 for (auto& pair : window_to_data_)
59 windows.insert(pair.first); 60 windows.insert(pair.first);
60 return windows; 61 return windows;
61 } 62 }
62 63
63 private: 64 private:
64 // WmWindowObserver: 65 // aura::WindowObserver:
65 void OnWindowDestroying(WmWindow* window) override { 66 void OnWindowDestroying(aura::Window* window) override {
66 window->RemoveObserver(this); 67 window->RemoveObserver(this);
67 window_to_data_.erase(window); 68 window_to_data_.erase(WmWindow::Get(window));
68 } 69 }
69 70
70 std::map<WmWindow*, std::unique_ptr<UserData>> window_to_data_; 71 std::map<WmWindow*, std::unique_ptr<UserData>> window_to_data_;
71 72
72 DISALLOW_COPY_AND_ASSIGN(WmWindowUserData); 73 DISALLOW_COPY_AND_ASSIGN(WmWindowUserData);
73 }; 74 };
74 75
75 } // namespace ash 76 } // namespace ash
76 77
77 #endif // ASH_COMMON_WM_WINDOW_USER_DATA_H_ 78 #endif // ASH_COMMON_WM_WINDOW_USER_DATA_H_
OLDNEW
« no previous file with comments | « ash/common/wm_window_unittest.cc ('k') | ash/display/screen_orientation_controller_chromeos.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698