Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6689)

Unified Diff: ash/common/wm/maximize_mode/maximize_mode_window_manager.h

Issue 2699033002: Replace WmWindowObserver with aura::WindowObserver. (Closed)
Patch Set: Check for null images in ShelfWindowWatcher. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/common/wm/lock_layout_manager.cc ('k') | ash/common/wm/maximize_mode/maximize_mode_window_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/common/wm/maximize_mode/maximize_mode_window_manager.h
diff --git a/ash/common/wm/maximize_mode/maximize_mode_window_manager.h b/ash/common/wm/maximize_mode/maximize_mode_window_manager.h
index a47ab2e37b2758364a1ee80e9ba1ca4f38b4d294..4033c522412c440791b749d017fe869527ab7421 100644
--- a/ash/common/wm/maximize_mode/maximize_mode_window_manager.h
+++ b/ash/common/wm/maximize_mode/maximize_mode_window_manager.h
@@ -13,8 +13,8 @@
#include "ash/ash_export.h"
#include "ash/common/shell_observer.h"
#include "ash/common/wm/window_state.h"
-#include "ash/common/wm_window_observer.h"
#include "base/macros.h"
+#include "ui/aura/window_observer.h"
#include "ui/display/display_observer.h"
namespace ash {
@@ -31,7 +31,7 @@ class MaximizeModeEventHandler;
// behind the window so that no other windows are visible and/or obscured.
// With the destruction of the manager all windows will be restored to their
// original state.
-class ASH_EXPORT MaximizeModeWindowManager : public WmWindowObserver,
+class ASH_EXPORT MaximizeModeWindowManager : public aura::WindowObserver,
public display::DisplayObserver,
public ShellObserver {
public:
@@ -55,15 +55,15 @@ class ASH_EXPORT MaximizeModeWindowManager : public WmWindowObserver,
void OnOverviewModeEnded() override;
// Overridden from WindowObserver:
- void OnWindowDestroying(WmWindow* window) override;
- void OnWindowTreeChanged(WmWindow* window,
- const TreeChangeParams& params) override;
- void OnWindowPropertyChanged(WmWindow* window,
- WmWindowProperty window_property) override;
- void OnWindowBoundsChanged(WmWindow* window,
+ void OnWindowDestroying(aura::Window* window) override;
+ void OnWindowHierarchyChanged(const HierarchyChangeParams& params) override;
+ void OnWindowPropertyChanged(aura::Window* window,
+ const void* key,
+ intptr_t old) override;
+ void OnWindowBoundsChanged(aura::Window* window,
const gfx::Rect& old_bounds,
const gfx::Rect& new_bounds) override;
- void OnWindowVisibilityChanged(WmWindow* window, bool visible) override;
+ void OnWindowVisibilityChanged(aura::Window* window, bool visible) override;
// display::DisplayObserver overrides:
void OnDisplayAdded(const display::Display& display) override;
@@ -114,7 +114,7 @@ class ASH_EXPORT MaximizeModeWindowManager : public WmWindowObserver,
void DisplayConfigurationChanged();
// Returns true when the |window| is a container window.
- bool IsContainerWindow(WmWindow* window);
+ bool IsContainerWindow(aura::Window* window);
// Add a backdrop behind the currently active window on each desktop.
void EnableBackdropBehindTopWindowOnEachDisplay(bool enable);
@@ -123,10 +123,10 @@ class ASH_EXPORT MaximizeModeWindowManager : public WmWindowObserver,
WindowToState window_state_map_;
// All container windows which have to be tracked.
- std::unordered_set<WmWindow*> observed_container_windows_;
+ std::unordered_set<aura::Window*> observed_container_windows_;
// Windows added to the container, but not yet shown.
- std::unordered_set<WmWindow*> added_windows_;
+ std::unordered_set<aura::Window*> added_windows_;
// True if all backdrops are hidden.
bool backdrops_hidden_;
« no previous file with comments | « ash/common/wm/lock_layout_manager.cc ('k') | ash/common/wm/maximize_mode/maximize_mode_window_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698