Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Unified Diff: ash/wm/video_detector.h

Issue 2699033002: Replace WmWindowObserver with aura::WindowObserver. (Closed)
Patch Set: Check for null images in ShelfWindowWatcher. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/wm/screen_pinning_controller.cc ('k') | ash/wm/video_detector.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/video_detector.h
diff --git a/ash/wm/video_detector.h b/ash/wm/video_detector.h
index 2eb42876b63f3d683c9def6f44b80956d8eeb973..5eb9804733bc5da81ba55e0744b515d2ea0ef866 100644
--- a/ash/wm/video_detector.h
+++ b/ash/wm/video_detector.h
@@ -11,7 +11,6 @@
#include "ash/ash_export.h"
#include "ash/common/shell_observer.h"
-#include "ash/common/wm_window_observer.h"
#include "base/compiler_specific.h"
#include "base/macros.h"
#include "base/observer_list.h"
@@ -36,8 +35,7 @@ namespace ash {
// continuous scrolling of a page.
class ASH_EXPORT VideoDetector : public aura::EnvObserver,
public aura::WindowObserver,
- public ShellObserver,
- public WmWindowObserver {
+ public ShellObserver {
public:
// State of detected video activity.
enum class State {
@@ -93,21 +91,17 @@ class ASH_EXPORT VideoDetector : public aura::EnvObserver,
// EnvObserver overrides.
void OnWindowInitialized(aura::Window* window) override;
- // WindowObserver overrides.
+ // aura::WindowObserver overrides.
void OnDelegatedFrameDamage(aura::Window* window,
const gfx::Rect& region) override;
void OnWindowDestroyed(aura::Window* window) override;
- void OnWindowDestroying(aura::Window* window) override {}
+ void OnWindowDestroying(aura::Window* window) override;
// ShellObserver overrides.
void OnAppTerminating() override;
void OnFullscreenStateChanged(bool is_fullscreen,
WmWindow* root_window) override;
- // WmWindowObserver overrides.
- void OnWindowDestroyed(WmWindow* window) override {}
- void OnWindowDestroying(WmWindow* window) override;
-
private:
// Called when video activity is observed in |window|.
void HandleVideoActivity(aura::Window* window, base::TimeTicks now);
@@ -126,7 +120,7 @@ class ASH_EXPORT VideoDetector : public aura::EnvObserver,
bool video_is_playing_;
// Currently-fullscreen root windows.
- std::set<WmWindow*> fullscreen_root_windows_;
+ std::set<aura::Window*> fullscreen_root_windows_;
// Maps from a window that we're tracking to information about it.
class WindowInfo;
@@ -143,7 +137,6 @@ class ASH_EXPORT VideoDetector : public aura::EnvObserver,
base::TimeTicks now_for_test_;
ScopedObserver<aura::Window, aura::WindowObserver> window_observer_manager_;
- ScopedObserver<WmWindow, WmWindowObserver> wm_window_observer_manager_;
bool is_shutting_down_;
« no previous file with comments | « ash/wm/screen_pinning_controller.cc ('k') | ash/wm/video_detector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698