|
Don't animate the download shelf when entering/exiting fullscreen.
On Views platforms, I could just barely perceive the animation, and it
added jank, not smoothness, to the transition. On Mac, the download
shelf animated in/out *after* the fullscreen transition, which was odd
and drew attention to it as it disappeared.
Now, the shelf appears/disappears as part of the transition — so on
Views it doesn't add jank, and on Mac it fades in/out along with the
rest of the window.
As an added bonus, this fixes a bug where windows on Mac grew by the
height of the downloads bar each time you enter/exit fullscreen. It
should also fix a flaky test on 10.9 by adding an option to hide/show
the shelf without animation.
BUG= 29629, 687447
Review-Url: https://codereview.chromium.org/2688413012
Cr-Commit-Position: refs/heads/master@{#451327}
Committed: https://chromium.googlesource.com/chromium/src/+/7578925d7cf03c4e5a721eb757fd7c35490b57a2
Total comments: 2
Total comments: 8
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+111 lines, -68 lines) |
Patch |
|
M |
chrome/browser/download/download_shelf.h
|
View
|
1
2
3
|
2 chunks |
+4 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/download/download_shelf.cc
|
View
|
1
2
3
|
4 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
|
M |
chrome/browser/download/download_shelf_unittest.cc
|
View
|
1
2
3
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/download/test_download_shelf.h
|
View
|
1
|
1 chunk |
+3 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/download/test_download_shelf.cc
|
View
|
1
|
2 chunks |
+9 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/browser.h
|
View
|
1
2
3
4
|
1 chunk |
+4 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/browser.cc
|
View
|
1
2
3
4
|
1 chunk |
+5 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/cocoa/browser_window_controller_private.mm
|
View
|
1
2
|
2 chunks |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/cocoa/download/download_shelf_controller.h
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/cocoa/download/download_shelf_controller.mm
|
View
|
|
2 chunks |
+6 lines, -5 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/cocoa/download/download_shelf_controller_unittest.mm
|
View
|
1
2
3
4
5
6
|
11 chunks |
+15 lines, -33 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/cocoa/download/download_shelf_mac.h
|
View
|
|
1 chunk |
+3 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/cocoa/download/download_shelf_mac.mm
|
View
|
|
1 chunk |
+14 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/cocoa/download/download_shelf_mac_unittest.mm
|
View
|
1
2
3
|
3 chunks |
+5 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/cocoa/view_id_util_browsertest.mm
|
View
|
1
2
3
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/exclusive_access/fullscreen_controller.h
|
View
|
1
2
|
1 chunk |
+3 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/exclusive_access/fullscreen_controller.cc
|
View
|
1
2
3
4
5
|
2 chunks |
+10 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/download/download_shelf_view.h
|
View
|
|
1 chunk |
+3 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/download/download_shelf_view.cc
|
View
|
|
2 chunks |
+13 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/browser_view.cc
|
View
|
1
2
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
Total messages: 45 (35 generated)
|