Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2209)

Unified Diff: chrome/browser/download/download_shelf_unittest.cc

Issue 2688413012: Don't animate the download shelf when entering/exiting fullscreen. (Closed)
Patch Set: Turn on animation for all tests except the one that was flaky due to animation. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/download/download_shelf.cc ('k') | chrome/browser/download/test_download_shelf.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_shelf_unittest.cc
diff --git a/chrome/browser/download/download_shelf_unittest.cc b/chrome/browser/download/download_shelf_unittest.cc
index c59e6a0cecc0bfc71c1f1a4af317522ee1b69d0f..097cc829c15d1a0a377c8f0de53c526d4d2079cb 100644
--- a/chrome/browser/download/download_shelf_unittest.cc
+++ b/chrome/browser/download/download_shelf_unittest.cc
@@ -94,7 +94,7 @@ DownloadShelfTest::DownloadShelfTest()
} // namespace
TEST_F(DownloadShelfTest, ClosesShelfWhenHidden) {
- shelf()->Show();
+ shelf()->Open();
EXPECT_TRUE(shelf()->IsShowing());
shelf()->Hide();
EXPECT_FALSE(shelf()->IsShowing());
@@ -103,7 +103,7 @@ TEST_F(DownloadShelfTest, ClosesShelfWhenHidden) {
}
TEST_F(DownloadShelfTest, CloseWhileHiddenPreventsShowOnUnhide) {
- shelf()->Show();
+ shelf()->Open();
shelf()->Hide();
shelf()->Close(DownloadShelf::AUTOMATIC);
shelf()->Unhide();
@@ -117,7 +117,7 @@ TEST_F(DownloadShelfTest, UnhideDoesntShowIfNotShownOnHide) {
}
TEST_F(DownloadShelfTest, AddDownloadWhileHiddenUnhides) {
- shelf()->Show();
+ shelf()->Open();
shelf()->Hide();
shelf()->AddDownload(download_item());
EXPECT_TRUE(shelf()->IsShowing());
« no previous file with comments | « chrome/browser/download/download_shelf.cc ('k') | chrome/browser/download/test_download_shelf.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698