Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1024)

Side by Side Diff: chrome/browser/ui/browser.h

Issue 2688413012: Don't animate the download shelf when entering/exiting fullscreen. (Closed)
Patch Set: Turn on animation for all tests except the one that was flaky due to animation. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/download/test_download_shelf.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_BROWSER_H_ 5 #ifndef CHROME_BROWSER_UI_BROWSER_H_
6 #define CHROME_BROWSER_UI_BROWSER_H_ 6 #define CHROME_BROWSER_UI_BROWSER_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <map> 10 #include <map>
(...skipping 350 matching lines...) Expand 10 before | Expand all | Expand 10 after
361 // Indicates whether or not this browser window can be closed, or 361 // Indicates whether or not this browser window can be closed, or
362 // would be blocked by in-progress downloads. 362 // would be blocked by in-progress downloads.
363 // If executing downloads would be cancelled by this window close, 363 // If executing downloads would be cancelled by this window close,
364 // then |*num_downloads_blocking| is updated with how many downloads 364 // then |*num_downloads_blocking| is updated with how many downloads
365 // would be canceled if the close continued. 365 // would be canceled if the close continued.
366 DownloadClosePreventionType OkToCloseWithInProgressDownloads( 366 DownloadClosePreventionType OkToCloseWithInProgressDownloads(
367 int* num_downloads_blocking) const; 367 int* num_downloads_blocking) const;
368 368
369 // External state change handling //////////////////////////////////////////// 369 // External state change handling ////////////////////////////////////////////
370 370
371 // Invoked when the fullscreen state of the window changes. 371 // BrowserWindow::EnterFullscreen invokes WindowFullscreenStateWillChange at
372 // BrowserWindow::EnterFullscreen invokes this after the window has become 372 // the beginning of a fullscreen transition, and WindowFullscreenStateChanged
373 // fullscreen. 373 // at the end.
374 void WindowFullscreenStateWillChange();
374 void WindowFullscreenStateChanged(); 375 void WindowFullscreenStateChanged();
375 376
376 // Assorted browser commands //////////////////////////////////////////////// 377 // Assorted browser commands ////////////////////////////////////////////////
377 378
378 // NOTE: Within each of the following sections, the IDs are ordered roughly by 379 // NOTE: Within each of the following sections, the IDs are ordered roughly by
379 // how they appear in the GUI/menus (left to right, top to bottom, etc.). 380 // how they appear in the GUI/menus (left to right, top to bottom, etc.).
380 381
381 // See the description of 382 // See the description of
382 // FullscreenController::ToggleFullscreenModeWithExtension. 383 // FullscreenController::ToggleFullscreenModeWithExtension.
383 void ToggleFullscreenModeWithExtension(const GURL& extension_url); 384 void ToggleFullscreenModeWithExtension(const GURL& extension_url);
(...skipping 638 matching lines...) Expand 10 before | Expand all | Expand 10 after
1022 // The following factory is used for chrome update coalescing. 1023 // The following factory is used for chrome update coalescing.
1023 base::WeakPtrFactory<Browser> chrome_updater_factory_; 1024 base::WeakPtrFactory<Browser> chrome_updater_factory_;
1024 1025
1025 // The following factory is used to close the frame at a later time. 1026 // The following factory is used to close the frame at a later time.
1026 base::WeakPtrFactory<Browser> weak_factory_; 1027 base::WeakPtrFactory<Browser> weak_factory_;
1027 1028
1028 DISALLOW_COPY_AND_ASSIGN(Browser); 1029 DISALLOW_COPY_AND_ASSIGN(Browser);
1029 }; 1030 };
1030 1031
1031 #endif // CHROME_BROWSER_UI_BROWSER_H_ 1032 #endif // CHROME_BROWSER_UI_BROWSER_H_
OLDNEW
« no previous file with comments | « chrome/browser/download/test_download_shelf.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698