Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Side by Side Diff: chrome/browser/ui/browser.cc

Issue 2688413012: Don't animate the download shelf when entering/exiting fullscreen. (Closed)
Patch Set: Turn on animation for all tests except the one that was flaky due to animation. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/browser.h" 5 #include "chrome/browser/ui/browser.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <algorithm> 9 #include <algorithm>
10 #include <string> 10 #include <string>
(...skipping 808 matching lines...) Expand 10 before | Expand all | Expand 10 after
819 return DOWNLOAD_CLOSE_LAST_WINDOW_IN_INCOGNITO_PROFILE; 819 return DOWNLOAD_CLOSE_LAST_WINDOW_IN_INCOGNITO_PROFILE;
820 } 820 }
821 821
822 // Those are the only conditions under which we will block shutdown. 822 // Those are the only conditions under which we will block shutdown.
823 return DOWNLOAD_CLOSE_OK; 823 return DOWNLOAD_CLOSE_OK;
824 } 824 }
825 825
826 //////////////////////////////////////////////////////////////////////////////// 826 ////////////////////////////////////////////////////////////////////////////////
827 // Browser, Tab adding/showing functions: 827 // Browser, Tab adding/showing functions:
828 828
829 void Browser::WindowFullscreenStateWillChange() {
830 exclusive_access_manager_->fullscreen_controller()
831 ->WindowFullscreenStateWillChange();
832 }
833
829 void Browser::WindowFullscreenStateChanged() { 834 void Browser::WindowFullscreenStateChanged() {
830 exclusive_access_manager_->fullscreen_controller() 835 exclusive_access_manager_->fullscreen_controller()
831 ->WindowFullscreenStateChanged(); 836 ->WindowFullscreenStateChanged();
832 command_controller_->FullscreenStateChanged(); 837 command_controller_->FullscreenStateChanged();
833 UpdateBookmarkBarState(BOOKMARK_BAR_STATE_CHANGE_TOGGLE_FULLSCREEN); 838 UpdateBookmarkBarState(BOOKMARK_BAR_STATE_CHANGE_TOGGLE_FULLSCREEN);
834 } 839 }
835 840
836 /////////////////////////////////////////////////////////////////////////////// 841 ///////////////////////////////////////////////////////////////////////////////
837 // Browser, Assorted browser commands: 842 // Browser, Assorted browser commands:
838 843
(...skipping 1826 matching lines...) Expand 10 before | Expand all | Expand 10 after
2665 // new window later, thus we need to navigate the window now. 2670 // new window later, thus we need to navigate the window now.
2666 if (contents) { 2671 if (contents) {
2667 contents->web_contents()->GetController().LoadURL( 2672 contents->web_contents()->GetController().LoadURL(
2668 target_url, content::Referrer(), ui::PAGE_TRANSITION_LINK, 2673 target_url, content::Referrer(), ui::PAGE_TRANSITION_LINK,
2669 std::string()); // No extra headers. 2674 std::string()); // No extra headers.
2670 } 2675 }
2671 } 2676 }
2672 2677
2673 return contents != NULL; 2678 return contents != NULL;
2674 } 2679 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/browser.h ('k') | chrome/browser/ui/cocoa/browser_window_controller_private.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698