chrome/browser/download/download_shelf.h - Issue 2688413012: Don't animate the download shelf when entering/exiting fullscreen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_shelf.h

Issue 2688413012: Don't animate the download shelf when entering/exiting fullscreen. (Closed)

Patch Set: Turn on animation for all tests except the one that was flaky due to animation. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/download/download_shelf.h

diff --git a/chrome/browser/download/download_shelf.h b/chrome/browser/download/download_shelf.h

index aefee262dae3e43d426c6bf8c0fb9bd09da7577a..aa4467f989465cbb75ec3a960c4b35bf4ff0c845 100644

--- a/chrome/browser/download/download_shelf.h

+++ b/chrome/browser/download/download_shelf.h

@@ -95,7 +95,7 @@ class DownloadShelf {

virtual bool IsClosing() const = 0;

// Opens the shelf.

- void Show();

+ void Open();

// Closes the shelf.

void Close(CloseReason reason);

@@ -114,8 +114,10 @@ class DownloadShelf {

protected:

virtual void DoAddDownload(content::DownloadItem* download) = 0;

- virtual void DoShow() = 0;

+ virtual void DoOpen() = 0;

virtual void DoClose(CloseReason reason) = 0;

+ virtual void DoHide() = 0;

+ virtual void DoUnhide() = 0;

// Time delay to wait before adding a transient download to the shelf.

// Protected virtual for testing.

« no previous file with comments | « no previous file | chrome/browser/download/download_shelf.cc » ('j') | no next file with comments »