Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: chrome/browser/download/download_shelf.cc

Issue 2688413012: Don't animate the download shelf when entering/exiting fullscreen. (Closed)
Patch Set: Turn on animation for all tests except the one that was flaky due to animation. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/download/download_shelf.h ('k') | chrome/browser/download/download_shelf_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_shelf.cc
diff --git a/chrome/browser/download/download_shelf.cc b/chrome/browser/download/download_shelf.cc
index e3172a425bac4622289fef6b8da18fc7e76de029..cf47b9d592dee5f950d53c401ca5d05d77d2f40d 100644
--- a/chrome/browser/download/download_shelf.cc
+++ b/chrome/browser/download/download_shelf.cc
@@ -149,12 +149,12 @@ void DownloadShelf::AddDownload(DownloadItem* download) {
}
}
-void DownloadShelf::Show() {
+void DownloadShelf::Open() {
if (is_hidden_) {
should_show_on_unhide_ = true;
return;
}
- DoShow();
+ DoOpen();
}
void DownloadShelf::Close(CloseReason reason) {
@@ -171,7 +171,7 @@ void DownloadShelf::Hide() {
is_hidden_ = true;
if (IsShowing()) {
should_show_on_unhide_ = true;
- DoClose(AUTOMATIC);
+ DoHide();
}
}
@@ -181,7 +181,7 @@ void DownloadShelf::Unhide() {
is_hidden_ = false;
if (should_show_on_unhide_) {
should_show_on_unhide_ = false;
- DoShow();
+ DoUnhide();
}
}
@@ -203,7 +203,7 @@ void DownloadShelf::ShowDownload(DownloadItem* download) {
if (is_hidden_)
Unhide();
- Show();
+ Open();
DoAddDownload(download);
// browser() can be NULL for tests.
« no previous file with comments | « chrome/browser/download/download_shelf.h ('k') | chrome/browser/download/download_shelf_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698