chrome/browser/ui/cocoa/browser_window_controller_private.mm - Issue 2688413012: Don't animate the download shelf when entering/exiting fullscreen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_private.mm

Issue 2688413012: Don't animate the download shelf when entering/exiting fullscreen. (Closed)

Patch Set: Turn on animation for all tests except the one that was flaky due to animation. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/browser_window_controller_private.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_controller_private.mm b/chrome/browser/ui/cocoa/browser_window_controller_private.mm

index f084fb039ddfc634afb1cc0415d6dd245e856c66..03216863ed3c72e7418b1d4dcbf398584a8e4f4f 100644

--- a/chrome/browser/ui/cocoa/browser_window_controller_private.mm

+++ b/chrome/browser/ui/cocoa/browser_window_controller_private.mm

@@ -610,6 +610,7 @@ willPositionSheet:(NSWindow*)sheet

[self setSheetHiddenForFullscreenTransition:YES];

[self adjustUIForEnteringFullscreen];

+ browser_->WindowFullscreenStateWillChange();

}

- (void)windowDidEnterFullScreen:(NSNotification*)notification {

@@ -700,6 +701,7 @@ willPositionSheet:(NSWindow*)sheet

} else {

[self adjustUIForExitingFullscreen];

}

+ browser_->WindowFullscreenStateWillChange();

}

- (void)windowDidExitFullScreen:(NSNotification*)notification {