Chrome sync: Put WeakPtrFactory members at the end

Chrome sync: Put WeakPtrFactory members at the end

BUG=303818
R=akalin@chromium.org, nhiroki@chromium.org
TBR=nhiroki@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227944

[dmichael (off chromium), 2013-10-08 22:12:59]

Please see the bug if you want context.

This is mostly mechanical, although I did have to make a WeakHandle non-const so
that it could be assigned in the constructor (since its Factory is no longer
initialized before it).

[akalin, 2013-10-08 22:22:35]

On 2013/10/08 22:12:59, dmichael wrote:
> Please see the bug if you want context.
> 
> This is mostly mechanical, although I did have to make a WeakHandle non-const
so
> that it could be assigned in the constructor (since its Factory is no longer
> initialized before it).

I don't see weak_handle.h being changed.

[akalin, 2013-10-08 22:26:03]

ah, i see what you mean.

lgtm.

https://codereview.chromium.org/26594002/diff/1/sync/notifier/non_blocking_in...
File sync/notifier/non_blocking_invalidator.cc (right):

https://codereview.chromium.org/26594002/diff/1/sync/notifier/non_blocking_in...
sync/notifier/non_blocking_invalidator.cc:145:
network_task_runner_(notifier_options.request_context_getter->
break after (?

[dmichael (off chromium), 2013-10-08 22:41:19]

Thanks!

https://codereview.chromium.org/26594002/diff/1/sync/notifier/non_blocking_in...
File sync/notifier/non_blocking_invalidator.cc (right):

https://codereview.chromium.org/26594002/diff/1/sync/notifier/non_blocking_in...
sync/notifier/non_blocking_invalidator.cc:145:
network_task_runner_(notifier_options.request_context_getter->
On 2013/10/08 22:26:04, akalin wrote:
> break after (?

Done.

[commit-bot: I haz the power, 2013-10-08 22:41:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmichael@chromium.org/26594002/11001

[commit-bot: I haz the power, 2013-10-09 02:39:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmichael@chromium.org/26594002/11001

[commit-bot: I haz the power, 2013-10-09 07:45:46]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[dmichael (off chromium), 2013-10-09 16:13:02]

nhiroki TBRed for chrome/browser/sync_file_system/drive_backend/*

It's pretty straightforward, so hopefully TBR is okay. Thanks!

[commit-bot: I haz the power, 2013-10-09 16:13:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmichael@chromium.org/26594002/11001

[nhiroki, 2013-10-09 16:16:34]

LGTM for chrome/browser/sync_file_system/drive_backend/*

[commit-bot: I haz the power, 2013-10-09 17:52:10]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...

[commit-bot: I haz the power, 2013-10-09 21:38:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmichael@chromium.org/26594002/27001

[commit-bot: I haz the power, 2013-10-10 00:50:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmichael@chromium.org/26594002/27001

[dmichael (off chromium), 2013-10-10 16:21:48]

Committed patchset #3 manually as r227944 (presubmit successful).

[Nico, 2013-10-12 06:32:54]

https://codereview.chromium.org/26594002/diff/27001/chrome/browser/sync_file_...
File chrome/browser/sync_file_system/drive_backend/sync_engine.cc (right):

https://codereview.chromium.org/26594002/diff/27001/chrome/browser/sync_file_...
chrome/browser/sync_file_system/drive_backend/sync_engine.cc:32:
task_manager_(weak_ptr_factory_.GetWeakPtr()),
Now weak_ptr_factory_ is uninitialized when used here:

../../chrome/browser/sync_file_system/drive_backend/sync_engine.cc:33:21:error:
field 'weak_ptr_factory_' is uninitialized when used here
[-Werror,-Wuninitialized]
      task_manager_(weak_ptr_factory_.GetWeakPtr()),
                    ^
1 error generated.