Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Side by Side Diff: chrome/browser/sync/glue/favicon_cache.h

Issue 26594002: Chrome sync: Put WeakPtrFactory members at the end (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge (see prior patch for try jobs) Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SYNC_GLUE_FAVICON_CACHE_H_ 5 #ifndef CHROME_BROWSER_SYNC_GLUE_FAVICON_CACHE_H_
6 #define CHROME_BROWSER_SYNC_GLUE_FAVICON_CACHE_H_ 6 #define CHROME_BROWSER_SYNC_GLUE_FAVICON_CACHE_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 10
(...skipping 196 matching lines...) Expand 10 before | Expand all | Expand 10 after
207 PageTaskMap page_task_map_; 207 PageTaskMap page_task_map_;
208 208
209 // Map of page and associated favicon urls. 209 // Map of page and associated favicon urls.
210 PageFaviconMap page_favicon_map_; 210 PageFaviconMap page_favicon_map_;
211 211
212 Profile* profile_; 212 Profile* profile_;
213 213
214 // TODO(zea): consider creating a favicon handler here for fetching unsynced 214 // TODO(zea): consider creating a favicon handler here for fetching unsynced
215 // favicons from the web. 215 // favicons from the web.
216 216
217 // Weak pointer factory for favicon loads.
218 base::WeakPtrFactory<FaviconCache> weak_ptr_factory_;
219
220 scoped_ptr<syncer::SyncChangeProcessor> favicon_images_sync_processor_; 217 scoped_ptr<syncer::SyncChangeProcessor> favicon_images_sync_processor_;
221 scoped_ptr<syncer::SyncChangeProcessor> favicon_tracking_sync_processor_; 218 scoped_ptr<syncer::SyncChangeProcessor> favicon_tracking_sync_processor_;
222 219
223 // For listening to history deletions. 220 // For listening to history deletions.
224 content::NotificationRegistrar notification_registrar_; 221 content::NotificationRegistrar notification_registrar_;
225 222
226 // Maximum number of favicons to sync. 0 means no limit. 223 // Maximum number of favicons to sync. 0 means no limit.
227 const size_t max_sync_favicon_limit_; 224 const size_t max_sync_favicon_limit_;
228 225
226 // Weak pointer factory for favicon loads.
227 base::WeakPtrFactory<FaviconCache> weak_ptr_factory_;
228
229 DISALLOW_COPY_AND_ASSIGN(FaviconCache); 229 DISALLOW_COPY_AND_ASSIGN(FaviconCache);
230 }; 230 };
231 231
232 } // namespace browser_sync 232 } // namespace browser_sync
233 233
234 #endif // CHROME_BROWSER_SYNC_GLUE_FAVICON_CACHE_H_ 234 #endif // CHROME_BROWSER_SYNC_GLUE_FAVICON_CACHE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698