Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: sync/notifier/non_blocking_invalidator.cc

Issue 26594002: Chrome sync: Put WeakPtrFactory members at the end (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « sync/notifier/non_blocking_invalidator.h ('k') | sync/notifier/sync_invalidation_listener.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "sync/notifier/non_blocking_invalidator.h" 5 #include "sync/notifier/non_blocking_invalidator.h"
6 6
7 #include <cstddef> 7 #include <cstddef>
8 8
9 #include "base/location.h" 9 #include "base/location.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
134 } 134 }
135 135
136 NonBlockingInvalidator::NonBlockingInvalidator( 136 NonBlockingInvalidator::NonBlockingInvalidator(
137 const notifier::NotifierOptions& notifier_options, 137 const notifier::NotifierOptions& notifier_options,
138 const std::string& invalidator_client_id, 138 const std::string& invalidator_client_id,
139 const InvalidationStateMap& initial_invalidation_state_map, 139 const InvalidationStateMap& initial_invalidation_state_map,
140 const std::string& invalidation_bootstrap_data, 140 const std::string& invalidation_bootstrap_data,
141 const WeakHandle<InvalidationStateTracker>& 141 const WeakHandle<InvalidationStateTracker>&
142 invalidation_state_tracker, 142 invalidation_state_tracker,
143 const std::string& client_info) 143 const std::string& client_info)
144 : weak_ptr_factory_(this), 144 : parent_task_runner_(base::ThreadTaskRunnerHandle::Get()),
145 core_( 145 network_task_runner_(notifier_options.request_context_getter->
akalin 2013/10/08 22:26:04 break after (?
dmichael (off chromium) 2013/10/08 22:41:19 Done.
146 new Core(MakeWeakHandle(weak_ptr_factory_.GetWeakPtr()))), 146 GetNetworkTaskRunner()),
147 parent_task_runner_( 147 weak_ptr_factory_(this) {
148 base::ThreadTaskRunnerHandle::Get()), 148 core_ = new Core(MakeWeakHandle(weak_ptr_factory_.GetWeakPtr()));
149 network_task_runner_(notifier_options.request_context_getter-> 149
150 GetNetworkTaskRunner()) {
151 if (!network_task_runner_->PostTask( 150 if (!network_task_runner_->PostTask(
152 FROM_HERE, 151 FROM_HERE,
153 base::Bind( 152 base::Bind(
154 &NonBlockingInvalidator::Core::Initialize, 153 &NonBlockingInvalidator::Core::Initialize,
155 core_.get(), 154 core_.get(),
156 notifier_options, 155 notifier_options,
157 invalidator_client_id, 156 invalidator_client_id,
158 initial_invalidation_state_map, 157 initial_invalidation_state_map,
159 invalidation_bootstrap_data, 158 invalidation_bootstrap_data,
160 invalidation_state_tracker, 159 invalidation_state_tracker,
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
232 registrar_.UpdateInvalidatorState(state); 231 registrar_.UpdateInvalidatorState(state);
233 } 232 }
234 233
235 void NonBlockingInvalidator::OnIncomingInvalidation( 234 void NonBlockingInvalidator::OnIncomingInvalidation(
236 const ObjectIdInvalidationMap& invalidation_map) { 235 const ObjectIdInvalidationMap& invalidation_map) {
237 DCHECK(parent_task_runner_->BelongsToCurrentThread()); 236 DCHECK(parent_task_runner_->BelongsToCurrentThread());
238 registrar_.DispatchInvalidationsToHandlers(invalidation_map); 237 registrar_.DispatchInvalidationsToHandlers(invalidation_map);
239 } 238 }
240 239
241 } // namespace syncer 240 } // namespace syncer
OLDNEW
« no previous file with comments | « sync/notifier/non_blocking_invalidator.h ('k') | sync/notifier/sync_invalidation_listener.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698