Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: chrome/browser/sync/glue/favicon_cache.h

Issue 26594002: Chrome sync: Put WeakPtrFactory members at the end (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge (see prior patch for try jobs) Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/favicon_cache.h
diff --git a/chrome/browser/sync/glue/favicon_cache.h b/chrome/browser/sync/glue/favicon_cache.h
index cb897f0ac8cc2a0bf459b54268eeaa75f9118a70..964f034773b65b656826ea3f829861885562584b 100644
--- a/chrome/browser/sync/glue/favicon_cache.h
+++ b/chrome/browser/sync/glue/favicon_cache.h
@@ -214,9 +214,6 @@ class FaviconCache : public syncer::SyncableService,
// TODO(zea): consider creating a favicon handler here for fetching unsynced
// favicons from the web.
- // Weak pointer factory for favicon loads.
- base::WeakPtrFactory<FaviconCache> weak_ptr_factory_;
-
scoped_ptr<syncer::SyncChangeProcessor> favicon_images_sync_processor_;
scoped_ptr<syncer::SyncChangeProcessor> favicon_tracking_sync_processor_;
@@ -226,6 +223,9 @@ class FaviconCache : public syncer::SyncableService,
// Maximum number of favicons to sync. 0 means no limit.
const size_t max_sync_favicon_limit_;
+ // Weak pointer factory for favicon loads.
+ base::WeakPtrFactory<FaviconCache> weak_ptr_factory_;
+
DISALLOW_COPY_AND_ASSIGN(FaviconCache);
};

Powered by Google App Engine
This is Rietveld 408576698