Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Unified Diff: chrome/browser/sync/glue/session_model_associator.cc

Issue 26594002: Chrome sync: Put WeakPtrFactory members at the end (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge (see prior patch for try jobs) Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/session_model_associator.cc
diff --git a/chrome/browser/sync/glue/session_model_associator.cc b/chrome/browser/sync/glue/session_model_associator.cc
index c5e1cd98e9d2e16f5610648c77647056fc2d5021..40711bd14c0033267d6bad631ec25837d5c1a107 100644
--- a/chrome/browser/sync/glue/session_model_associator.cc
+++ b/chrome/browser/sync/glue/session_model_associator.cc
@@ -123,11 +123,11 @@ SessionModelAssociator::SessionModelAssociator(
stale_session_threshold_days_(kDefaultStaleSessionThresholdDays),
setup_for_test_(false),
waiting_for_change_(false),
- test_weak_factory_(this),
profile_(sync_service->profile()),
error_handler_(error_handler),
favicon_cache_(profile_,
- sync_service->current_experiments().favicon_sync_limit) {
+ sync_service->current_experiments().favicon_sync_limit),
+ test_weak_factory_(this) {
DCHECK(CalledOnValidThread());
DCHECK(sync_service_);
DCHECK(profile_);
@@ -141,10 +141,10 @@ SessionModelAssociator::SessionModelAssociator(ProfileSyncService* sync_service,
stale_session_threshold_days_(kDefaultStaleSessionThresholdDays),
setup_for_test_(setup_for_test),
waiting_for_change_(false),
- test_weak_factory_(this),
profile_(sync_service->profile()),
error_handler_(NULL),
- favicon_cache_(profile_, kMaxSyncFavicons) {
+ favicon_cache_(profile_, kMaxSyncFavicons),
+ test_weak_factory_(this) {
DCHECK(CalledOnValidThread());
DCHECK(sync_service_);
DCHECK(profile_);

Powered by Google App Engine
This is Rietveld 408576698