chrome/browser/sync/glue/favicon_cache.cc - Issue 26594002: Chrome sync: Put WeakPtrFactory members at the end

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/favicon_cache.cc

Issue 26594002: Chrome sync: Put WeakPtrFactory members at the end (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: merge (see prior patch for try jobs) Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/glue/favicon_cache.cc

diff --git a/chrome/browser/sync/glue/favicon_cache.cc b/chrome/browser/sync/glue/favicon_cache.cc

index 50eefb5c14417a3c3aebd961cfe0150aa72de45c..bda0925201f0b03742ec12d6d44624821f47069b 100644

--- a/chrome/browser/sync/glue/favicon_cache.cc

+++ b/chrome/browser/sync/glue/favicon_cache.cc

@@ -227,8 +227,8 @@ bool FaviconInfoHasValidTypeData(const SyncedFaviconInfo& favicon_info,

FaviconCache::FaviconCache(Profile* profile, int max_sync_favicon_limit)

: profile_(profile),

- weak_ptr_factory_(this),

- max_sync_favicon_limit_(max_sync_favicon_limit) {

+ max_sync_favicon_limit_(max_sync_favicon_limit),

+ weak_ptr_factory_(this) {

notification_registrar_.Add(this,

chrome::NOTIFICATION_HISTORY_URLS_DELETED,

content::Source<Profile>(profile_));