Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: sync/notifier/sync_invalidation_listener.h

Issue 26594002: Chrome sync: Put WeakPtrFactory members at the end (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge (see prior patch for try jobs) Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // A simple wrapper around invalidation::InvalidationClient that 5 // A simple wrapper around invalidation::InvalidationClient that
6 // handles all the startup/shutdown details and hookups. 6 // handles all the startup/shutdown details and hookups.
7 7
8 #ifndef SYNC_NOTIFIER_SYNC_INVALIDATION_LISTENER_H_ 8 #ifndef SYNC_NOTIFIER_SYNC_INVALIDATION_LISTENER_H_
9 #define SYNC_NOTIFIER_SYNC_INVALIDATION_LISTENER_H_ 9 #define SYNC_NOTIFIER_SYNC_INVALIDATION_LISTENER_H_
10 10
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 void EmitInvalidation(const ObjectIdSet& ids, 158 void EmitInvalidation(const ObjectIdSet& ids,
159 int64 version, 159 int64 version,
160 const std::string& payload, 160 const std::string& payload,
161 invalidation::InvalidationClient* client, 161 invalidation::InvalidationClient* client,
162 const invalidation::AckHandle& ack_handle, 162 const invalidation::AckHandle& ack_handle,
163 const AckHandleMap& local_ack_handles); 163 const AckHandleMap& local_ack_handles);
164 164
165 // AckTracker::Delegate implementation. 165 // AckTracker::Delegate implementation.
166 virtual void OnTimeout(const ObjectIdSet& ids) OVERRIDE; 166 virtual void OnTimeout(const ObjectIdSet& ids) OVERRIDE;
167 167
168 base::WeakPtrFactory<SyncInvalidationListener> weak_ptr_factory_;
169 AckTracker ack_tracker_; 168 AckTracker ack_tracker_;
170 169
171 // Owned by |sync_system_resources_|. 170 // Owned by |sync_system_resources_|.
172 notifier::PushClient* const push_client_; 171 notifier::PushClient* const push_client_;
173 SyncSystemResources sync_system_resources_; 172 SyncSystemResources sync_system_resources_;
174 InvalidationStateMap invalidation_state_map_; 173 InvalidationStateMap invalidation_state_map_;
175 WeakHandle<InvalidationStateTracker> invalidation_state_tracker_; 174 WeakHandle<InvalidationStateTracker> invalidation_state_tracker_;
176 Delegate* delegate_; 175 Delegate* delegate_;
177 scoped_ptr<invalidation::InvalidationClient> invalidation_client_; 176 scoped_ptr<invalidation::InvalidationClient> invalidation_client_;
178 scoped_ptr<RegistrationManager> registration_manager_; 177 scoped_ptr<RegistrationManager> registration_manager_;
179 // Stored to pass to |registration_manager_| on start. 178 // Stored to pass to |registration_manager_| on start.
180 ObjectIdSet registered_ids_; 179 ObjectIdSet registered_ids_;
181 180
182 // The states of the ticl and the push client. 181 // The states of the ticl and the push client.
183 InvalidatorState ticl_state_; 182 InvalidatorState ticl_state_;
184 InvalidatorState push_client_state_; 183 InvalidatorState push_client_state_;
185 184
185 base::WeakPtrFactory<SyncInvalidationListener> weak_ptr_factory_;
186
186 DISALLOW_COPY_AND_ASSIGN(SyncInvalidationListener); 187 DISALLOW_COPY_AND_ASSIGN(SyncInvalidationListener);
187 }; 188 };
188 189
189 } // namespace syncer 190 } // namespace syncer
190 191
191 #endif // SYNC_NOTIFIER_SYNC_INVALIDATION_LISTENER_H_ 192 #endif // SYNC_NOTIFIER_SYNC_INVALIDATION_LISTENER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698