chrome/browser/sync_file_system/drive_backend/sync_engine.cc - Issue 26594002: Chrome sync: Put WeakPtrFactory members at the end

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync_file_system/drive_backend/sync_engine.cc

Issue 26594002: Chrome sync: Put WeakPtrFactory members at the end (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: merge (see prior patch for try jobs) Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync_file_system/drive_backend/sync_engine.cc

diff --git a/chrome/browser/sync_file_system/drive_backend/sync_engine.cc b/chrome/browser/sync_file_system/drive_backend/sync_engine.cc

index 0acc6f56f531f7cdaced05388c8486c4387d4282..b7a81abef6b06aa098ae8438bbc4707bdafb7cc1 100644

--- a/chrome/browser/sync_file_system/drive_backend/sync_engine.cc

+++ b/chrome/browser/sync_file_system/drive_backend/sync_engine.cc

@@ -29,8 +29,8 @@ SyncEngine::SyncEngine(

drive_service_(drive_service.Pass()),

notification_manager_(notification_manager),

extension_service_(extension_service),

- weak_ptr_factory_(this),

- task_manager_(weak_ptr_factory_.GetWeakPtr()) {

+ task_manager_(weak_ptr_factory_.GetWeakPtr()),

Nico 2013/10/12 06:32:54 Now weak_ptr_factory_ is uninitialized when used h

+ weak_ptr_factory_(this) {

}

SyncEngine::~SyncEngine() {