Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Issue 2646623002: cc: Remove all blimp code from cc. (Closed)

Created:
3 years, 11 months ago by Khushal
Modified:
3 years, 10 months ago
CC:
cc-bugs_chromium.org, chromium-reviews, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove all blimp code from cc. This change removes all code in cc/blimp and cc that was used only by blimp, including the proto files, serialization code and related tests. BUG=677556 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2646623002 Cr-Commit-Position: refs/heads/master@{#445161} Committed: https://chromium.googlesource.com/chromium/src/+/54203a1937cde8d7305b2f94110a91298a4bc2c3

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : build fix #

Patch Set 4 : test build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -8468 lines) Patch
M cc/BUILD.gn View 1 2 3 14 chunks +6 lines, -61 lines 0 comments Download
D cc/blimp/client_picture_cache.h View 1 chunk +0 lines, -46 lines 0 comments Download
D cc/blimp/compositor_proto_state.h View 1 chunk +0 lines, -38 lines 0 comments Download
D cc/blimp/compositor_proto_state.cc View 1 chunk +0 lines, -16 lines 0 comments Download
D cc/blimp/compositor_state_deserializer.h View 1 chunk +0 lines, -152 lines 0 comments Download
D cc/blimp/compositor_state_deserializer.cc View 1 chunk +0 lines, -556 lines 0 comments Download
D cc/blimp/compositor_state_deserializer_unittest.cc View 1 chunk +0 lines, -404 lines 0 comments Download
D cc/blimp/deserialized_content_layer_client.h View 1 chunk +0 lines, -42 lines 0 comments Download
D cc/blimp/deserialized_content_layer_client.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D cc/blimp/engine_picture_cache.h View 1 chunk +0 lines, -33 lines 0 comments Download
D cc/blimp/image_serialization_processor.h View 1 chunk +0 lines, -27 lines 0 comments Download
D cc/blimp/layer_factory.h View 1 chunk +0 lines, -49 lines 0 comments Download
D cc/blimp/layer_tree_host_remote.h View 1 chunk +0 lines, -185 lines 0 comments Download
D cc/blimp/layer_tree_host_remote.cc View 1 chunk +0 lines, -536 lines 0 comments Download
D cc/blimp/layer_tree_host_remote_unittest.cc View 1 chunk +0 lines, -538 lines 0 comments Download
D cc/blimp/layer_tree_host_unittest_serialization.cc View 1 chunk +0 lines, -412 lines 0 comments Download
D cc/blimp/picture_data.h View 1 chunk +0 lines, -28 lines 0 comments Download
D cc/blimp/picture_data.cc View 1 chunk +0 lines, -16 lines 0 comments Download
D cc/blimp/picture_data_conversions.h View 1 chunk +0 lines, -29 lines 0 comments Download
D cc/blimp/picture_data_conversions.cc View 1 chunk +0 lines, -46 lines 0 comments Download
D cc/blimp/picture_data_conversions_unittest.cc View 1 chunk +0 lines, -71 lines 0 comments Download
D cc/blimp/remote_compositor_bridge.h View 1 chunk +0 lines, -54 lines 0 comments Download
D cc/blimp/remote_compositor_bridge.cc View 1 chunk +0 lines, -17 lines 0 comments Download
D cc/blimp/remote_compositor_bridge_client.h View 1 chunk +0 lines, -42 lines 0 comments Download
D cc/blimp/synced_property_remote.h View 1 chunk +0 lines, -122 lines 0 comments Download
D cc/blimp/synced_property_remote_unittest.cc View 1 chunk +0 lines, -57 lines 0 comments Download
M cc/input/layer_selection_bound.h View 2 chunks +0 lines, -13 lines 0 comments Download
M cc/input/layer_selection_bound.cc View 2 chunks +0 lines, -70 lines 0 comments Download
D cc/input/layer_selection_bound_unittest.cc View 1 chunk +0 lines, -76 lines 0 comments Download
M cc/layers/layer.h View 3 chunks +0 lines, -32 lines 0 comments Download
M cc/layers/layer.cc View 3 chunks +0 lines, -88 lines 0 comments Download
M cc/layers/layer_position_constraint.h View 2 chunks +0 lines, -7 lines 0 comments Download
M cc/layers/layer_position_constraint.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M cc/layers/layer_position_constraint_unittest.cc View 2 chunks +0 lines, -27 lines 0 comments Download
M cc/layers/layer_sticky_position_constraint.h View 2 chunks +0 lines, -7 lines 0 comments Download
M cc/layers/layer_sticky_position_constraint.cc View 2 chunks +0 lines, -40 lines 0 comments Download
M cc/layers/picture_layer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/layers/picture_layer.cc View 2 chunks +0 lines, -34 lines 0 comments Download
M cc/layers/picture_layer_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/layers/solid_color_scrollbar_layer.h View 2 chunks +0 lines, -4 lines 0 comments Download
M cc/layers/solid_color_scrollbar_layer.cc View 3 chunks +0 lines, -23 lines 0 comments Download
M cc/output/begin_frame_args.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/playback/clip_display_item.h View 2 chunks +0 lines, -4 lines 0 comments Download
M cc/playback/clip_display_item.cc View 4 chunks +0 lines, -39 lines 0 comments Download
M cc/playback/clip_path_display_item.h View 2 chunks +0 lines, -4 lines 0 comments Download
M cc/playback/clip_path_display_item.cc View 4 chunks +0 lines, -43 lines 0 comments Download
M cc/playback/compositing_display_item.h View 2 chunks +0 lines, -4 lines 0 comments Download
M cc/playback/compositing_display_item.cc View 4 chunks +0 lines, -59 lines 0 comments Download
M cc/playback/display_item.h View 2 chunks +0 lines, -5 lines 0 comments Download
M cc/playback/display_item_list.h View 2 chunks +0 lines, -16 lines 0 comments Download
M cc/playback/display_item_list.cc View 3 chunks +0 lines, -42 lines 0 comments Download
M cc/playback/display_item_list_settings.h View 1 chunk +0 lines, -7 lines 0 comments Download
M cc/playback/display_item_list_settings.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M cc/playback/display_item_list_unittest.cc View 2 chunks +0 lines, -214 lines 0 comments Download
D cc/playback/display_item_proto_factory.h View 1 chunk +0 lines, -38 lines 0 comments Download
D cc/playback/display_item_proto_factory.cc View 1 chunk +0 lines, -73 lines 0 comments Download
M cc/playback/drawing_display_item.h View 1 chunk +0 lines, -5 lines 0 comments Download
M cc/playback/drawing_display_item.cc View 3 chunks +0 lines, -35 lines 0 comments Download
M cc/playback/filter_display_item.h View 2 chunks +0 lines, -4 lines 0 comments Download
M cc/playback/filter_display_item.cc View 4 chunks +0 lines, -33 lines 0 comments Download
M cc/playback/float_clip_display_item.h View 2 chunks +0 lines, -4 lines 0 comments Download
M cc/playback/float_clip_display_item.cc View 4 chunks +0 lines, -29 lines 0 comments Download
M cc/playback/recording_source.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/playback/recording_source_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/playback/transform_display_item.h View 2 chunks +0 lines, -4 lines 0 comments Download
M cc/playback/transform_display_item.cc View 4 chunks +0 lines, -29 lines 0 comments Download
D cc/proto/BUILD.gn View 1 chunk +0 lines, -71 lines 0 comments Download
D cc/proto/base_conversions.h View 1 chunk +0 lines, -21 lines 0 comments Download
D cc/proto/base_conversions.cc View 1 chunk +0 lines, -23 lines 0 comments Download
D cc/proto/base_conversions_unittest.cc View 1 chunk +0 lines, -30 lines 0 comments Download
D cc/proto/cc_conversions.h View 1 chunk +0 lines, -34 lines 0 comments Download
D cc/proto/cc_conversions.cc View 1 chunk +0 lines, -48 lines 0 comments Download
D cc/proto/cc_conversions_unittest.cc View 1 chunk +0 lines, -65 lines 0 comments Download
D cc/proto/cc_proto_export.h View 1 chunk +0 lines, -29 lines 0 comments Download
D cc/proto/client_state_update.proto View 1 chunk +0 lines, -21 lines 0 comments Download
D cc/proto/compositor_message.proto View 1 chunk +0 lines, -40 lines 0 comments Download
D cc/proto/display_item.proto View 1 chunk +0 lines, -97 lines 0 comments Download
D cc/proto/gfx_conversions.h View 1 chunk +0 lines, -82 lines 0 comments Download
D cc/proto/gfx_conversions.cc View 1 chunk +0 lines, -155 lines 0 comments Download
D cc/proto/gfx_conversions_unittest.cc View 1 chunk +0 lines, -294 lines 0 comments Download
D cc/proto/layer.proto View 1 chunk +0 lines, -145 lines 0 comments Download
D cc/proto/layer_position_constraint.proto View 1 chunk +0 lines, -15 lines 0 comments Download
D cc/proto/layer_selection_bound.proto View 1 chunk +0 lines, -33 lines 0 comments Download
D cc/proto/layer_sticky_position_constraint.proto View 1 chunk +0 lines, -30 lines 0 comments Download
D cc/proto/layer_tree.proto View 1 chunk +0 lines, -44 lines 0 comments Download
D cc/proto/layer_tree_host.proto View 1 chunk +0 lines, -31 lines 0 comments Download
D cc/proto/point.proto View 1 chunk +0 lines, -14 lines 0 comments Download
D cc/proto/point3f.proto View 1 chunk +0 lines, -15 lines 0 comments Download
D cc/proto/pointf.proto View 1 chunk +0 lines, -14 lines 0 comments Download
D cc/proto/rect.proto View 1 chunk +0 lines, -17 lines 0 comments Download
D cc/proto/rectf.proto View 1 chunk +0 lines, -17 lines 0 comments Download
D cc/proto/region.proto View 1 chunk +0 lines, -15 lines 0 comments Download
D cc/proto/scroll_offset.proto View 1 chunk +0 lines, -14 lines 0 comments Download
D cc/proto/size.proto View 1 chunk +0 lines, -14 lines 0 comments Download
D cc/proto/sizef.proto View 1 chunk +0 lines, -14 lines 0 comments Download
D cc/proto/skclipop.proto View 1 chunk +0 lines, -20 lines 0 comments Download
D cc/proto/skia_conversions.h View 1 chunk +0 lines, -32 lines 0 comments Download
D cc/proto/skia_conversions.cc View 1 chunk +0 lines, -186 lines 0 comments Download
D cc/proto/skia_conversions_unittest.cc View 1 chunk +0 lines, -67 lines 0 comments Download
D cc/proto/skregion.proto View 1 chunk +0 lines, -20 lines 0 comments Download
D cc/proto/skrrect.proto View 1 chunk +0 lines, -20 lines 0 comments Download
D cc/proto/skxfermode.proto View 1 chunk +0 lines, -46 lines 0 comments Download
D cc/proto/transform.proto View 1 chunk +0 lines, -15 lines 0 comments Download
D cc/proto/vector2d.proto View 1 chunk +0 lines, -14 lines 0 comments Download
D cc/proto/vector2df.proto View 1 chunk +0 lines, -14 lines 0 comments Download
D cc/test/fake_client_picture_cache.h View 1 chunk +0 lines, -41 lines 0 comments Download
D cc/test/fake_client_picture_cache.cc View 1 chunk +0 lines, -37 lines 0 comments Download
D cc/test/fake_engine_picture_cache.h View 1 chunk +0 lines, -43 lines 0 comments Download
D cc/test/fake_engine_picture_cache.cc View 1 chunk +0 lines, -51 lines 0 comments Download
D cc/test/fake_image_serialization_processor.h View 1 chunk +0 lines, -36 lines 0 comments Download
D cc/test/fake_image_serialization_processor.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M cc/test/fake_layer_tree_host.h View 3 chunks +0 lines, -9 lines 0 comments Download
M cc/test/fake_layer_tree_host.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M cc/test/fake_picture_layer.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/test/fake_picture_layer.cc View 2 chunks +0 lines, -6 lines 0 comments Download
D cc/test/fake_remote_compositor_bridge.h View 1 chunk +0 lines, -46 lines 0 comments Download
D cc/test/fake_remote_compositor_bridge.cc View 1 chunk +0 lines, -44 lines 0 comments Download
D cc/test/layer_tree_host_remote_for_testing.h View 1 chunk +0 lines, -104 lines 0 comments Download
D cc/test/layer_tree_host_remote_for_testing.cc View 1 chunk +0 lines, -313 lines 0 comments Download
M cc/test/layer_tree_test.h View 3 chunks +0 lines, -12 lines 0 comments Download
M cc/test/layer_tree_test.cc View 7 chunks +7 lines, -86 lines 0 comments Download
D cc/test/picture_cache_model.h View 1 chunk +0 lines, -40 lines 0 comments Download
D cc/test/picture_cache_model.cc View 1 chunk +0 lines, -41 lines 0 comments Download
M cc/test/push_properties_counting_layer.h View 2 chunks +0 lines, -3 lines 0 comments Download
M cc/test/push_properties_counting_layer.cc View 1 chunk +0 lines, -11 lines 0 comments Download
D cc/test/remote_client_layer_factory.h View 1 chunk +0 lines, -42 lines 0 comments Download
D cc/test/remote_client_layer_factory.cc View 1 chunk +0 lines, -69 lines 0 comments Download
D cc/test/remote_compositor_test.h View 1 chunk +0 lines, -67 lines 0 comments Download
D cc/test/remote_compositor_test.cc View 1 chunk +0 lines, -129 lines 0 comments Download
D cc/test/serialization_test_utils.h View 1 chunk +0 lines, -36 lines 0 comments Download
D cc/test/serialization_test_utils.cc View 1 chunk +0 lines, -256 lines 0 comments Download
M cc/trees/clip_node.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/trees/compositor_mode.h View 1 chunk +1 line, -4 lines 0 comments Download
M cc/trees/effect_node.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/trees/layer_tree.h View 4 chunks +0 lines, -27 lines 0 comments Download
M cc/trees/layer_tree.cc View 2 chunks +0 lines, -54 lines 0 comments Download
M cc/trees/layer_tree_host_in_process.h View 5 chunks +0 lines, -21 lines 0 comments Download
M cc/trees/layer_tree_host_in_process.cc View 3 chunks +0 lines, -24 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 67 chunks +39 lines, -110 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_scroll.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_settings.h View 1 2 chunks +0 lines, -7 lines 0 comments Download
M cc/trees/layer_tree_settings.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/property_tree.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/scroll_node.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/transform_node.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 35 (19 generated)
Khushal
This depends on the change that removes all cc/blimp dependencies from content first.
3 years, 11 months ago (2017-01-18 21:42:27 UTC) #3
enne (OOO)
lgtm
3 years, 11 months ago (2017-01-18 22:20:01 UTC) #5
vmpstr
lgtm
3 years, 11 months ago (2017-01-19 23:26:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2646623002/1
3 years, 11 months ago (2017-01-20 01:38:37 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/351793)
3 years, 11 months ago (2017-01-20 02:46:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2646623002/20001
3 years, 11 months ago (2017-01-20 02:57:52 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/351816)
3 years, 11 months ago (2017-01-20 04:04:59 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2646623002/20001
3 years, 11 months ago (2017-01-20 05:56:32 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/351920)
3 years, 11 months ago (2017-01-20 07:10:15 UTC) #19
Khushal
Why is this failing on files I didn't change? T_T e:\b\c\b\win\src\cc\quads\draw_polygon.cc(107): error C2220: warning treated ...
3 years, 11 months ago (2017-01-20 18:10:15 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2646623002/40001
3 years, 11 months ago (2017-01-20 18:44:18 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/352196)
3 years, 11 months ago (2017-01-20 19:41:20 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2646623002/50001
3 years, 11 months ago (2017-01-20 19:48:26 UTC) #28
commit-bot: I haz the power
Committed patchset #4 (id:50001) as https://chromium.googlesource.com/chromium/src/+/54203a1937cde8d7305b2f94110a91298a4bc2c3
3 years, 11 months ago (2017-01-20 21:06:35 UTC) #31
Wez
Hallo avi@chromium.org! Due to a depot_tools patch which mistakenly removed the OWNERS check for non-source ...
3 years, 10 months ago (2017-02-08 17:59:35 UTC) #34
Avi (use Gerrit)
3 years, 10 months ago (2017-02-08 18:00:52 UTC) #35
Message was sent while issue was closed.
On 2017/02/08 17:59:35, Wez wrote:
> Hallo mailto:avi@chromium.org!
> Due to a depot_tools patch which mistakenly removed the OWNERS check for
> non-source files (see crbug.com/684270), the following files landed in this CL
> and need a retrospective review from you:
> 	content/renderer/BUILD.gn
> Thanks,
> Wez

This removes a DEPS entry, so BUILD.gn has my L👍TM.

lgtm

Powered by Google App Engine
This is Rietveld 408576698