Clean up unneeded JavaScript dialog parameter.

Clean up unneeded JavaScript dialog parameter.

Removes a parameter unneeded after https://codereview.chromium.org/2641173004.

BUG=682060
TEST=none

Review-Url: https://codereview.chromium.org/2639893002
Cr-Commit-Position: refs/heads/master@{#445273}
Committed: https://chromium.googlesource.com/chromium/src/+/6879fcfed049c28357eaa85c6d9a0126db54c0d7

[Avi (use Gerrit), 2017-01-18 06:38:37]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 06:38:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2017-01-18 06:47:51]

Description was changed from

==========
Make the callback from JavaScript dialogs even when closing a WebContents.

Otherwise, other WebContentses sharing that render process will hang.

This removes the "suppress_callbacks" parameter that turned out to be a bad
idea.

BUG=682060
==========

to

==========
Make the callback from JavaScript dialogs even when closing a WebContents.

Otherwise, other WebContentses sharing that render process will hang.

This removes the "suppress_callbacks" parameter that turned out to be a bad
idea. I was afraid of a crash doing the callback, so I added the test
JavaScriptDialogTest.ClosingPageWithSubframeAlertingDoesntCrash to catch it. The
other new test, JavaScriptDialogTest.ClosingPageSharingRendererDoesntHang, tests
for the bug, and passes with this fix.

BUG=682060
TEST=as noted
==========

[Avi (use Gerrit), 2017-01-18 06:48:18]

Description was changed from

==========
Make the callback from JavaScript dialogs even when closing a WebContents.

Otherwise, other WebContentses sharing that render process will hang.

This removes the "suppress_callbacks" parameter that turned out to be a bad
idea. I was afraid of a crash doing the callback, so I added the test
JavaScriptDialogTest.ClosingPageWithSubframeAlertingDoesntCrash to catch it. The
other new test, JavaScriptDialogTest.ClosingPageSharingRendererDoesntHang, tests
for the bug, and passes with this fix.

BUG=682060
TEST=as noted
==========

to

==========
Make the callback from JavaScript dialogs even when closing a WebContents.

Otherwise, other WebContentses sharing that render process will hang.

This removes the "suppress_callbacks" parameter that turned out to be a bad
idea. I was afraid of a crash doing the callback, so I added the test
JavaScriptDialogTest.ClosingPageWithSubframeAlertingDoesntCrash to make sure it
doesn't happen. (It doesn't.) The other new test,
JavaScriptDialogTest.ClosingPageSharingRendererDoesntHang, tests for the bug,
and passes with this fix.

BUG=682060
TEST=as noted
==========

[commit-bot: I haz the power, 2017-01-18 07:20:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 07:20:51]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2017-01-18 07:23:19]

avi@chromium.org changed reviewers:
+ jam@chromium.org

[Avi (use Gerrit), 2017-01-18 07:23:20]

John, please take a look.

The key is in the JavaScript dialog tab helper, always sending a response IPC.
The sweeping changes are just the removal of a bad idea that didn't turn out.

Tests included, one for the thing that I feared would happen if I were to send
the IPC (turns out my fears were unfounded) and one for the actual bug that this
change fixes.

[Avi (use Gerrit), 2017-01-19 20:02:50]

avi@chromium.org changed reviewers:
+ brettw@chromium.org

[Avi (use Gerrit), 2017-01-19 20:02:51]

Brett: John is out; can you take this?

We always need to send the reply IPC to revive the render process, but I need a
wide stamp to remove the bad idea that I committed all over the repo.

[Avi (use Gerrit), 2017-01-19 21:06:20]

Description was changed from

==========
Make the callback from JavaScript dialogs even when closing a WebContents.

Otherwise, other WebContentses sharing that render process will hang.

This removes the "suppress_callbacks" parameter that turned out to be a bad
idea. I was afraid of a crash doing the callback, so I added the test
JavaScriptDialogTest.ClosingPageWithSubframeAlertingDoesntCrash to make sure it
doesn't happen. (It doesn't.) The other new test,
JavaScriptDialogTest.ClosingPageSharingRendererDoesntHang, tests for the bug,
and passes with this fix.

BUG=682060
TEST=as noted
==========

to

==========
Clean up unneeded JavaScript dialog parameter.

Removes a parameter unneeded after https://codereview.chromium.org/2641173004.

BUG=682060
TEST=none
==========

[Avi (use Gerrit), 2017-01-19 21:06:28]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 21:06:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2017-01-19 21:07:16]

On 2017/01/19 20:02:51, Avi (offsites OOO 17Jan-2Feb) wrote:
> Brett: John is out; can you take this?
> 
> We always need to send the reply IPC to revive the render process, but I need
a
> wide stamp to remove the bad idea that I committed all over the repo.

Actually, I'm splitting out the fix; this is just the cleanup.

[commit-bot: I haz the power, 2017-01-19 21:55:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 21:55:43]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2017-01-20 00:58:17]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 00:59:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 02:06:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 02:06:56]

Dry run: This issue passed the CQ dry run.

[jam, 2017-01-21 01:42:52]

lgtm

[Avi (use Gerrit), 2017-01-21 04:07:59]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2017-01-21 04:08:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-21 05:27:57]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484971679831090,
"parent_rev": "0e03a131eaf48ffbd708263f5e86be5b4f0c486f", "commit_rev":
"6879fcfed049c28357eaa85c6d9a0126db54c0d7"}

[commit-bot: I haz the power, 2017-01-21 05:28:27]

Description was changed from

==========
Clean up unneeded JavaScript dialog parameter.

Removes a parameter unneeded after https://codereview.chromium.org/2641173004.

BUG=682060
TEST=none
==========

to

==========
Clean up unneeded JavaScript dialog parameter.

Removes a parameter unneeded after https://codereview.chromium.org/2641173004.

BUG=682060
TEST=none

Review-Url: https://codereview.chromium.org/2639893002
Cr-Commit-Position: refs/heads/master@{#445273}
Committed:
https://chromium.googlesource.com/chromium/src/+/6879fcfed049c28357eaa85c6d9a...
==========

[commit-bot: I haz the power, 2017-01-21 05:28:28]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6879fcfed049c28357eaa85c6d9a...