Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h

Issue 2639893002: Clean up unneeded JavaScript dialog parameter. (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_JAVASCRIPT_DIALOGS_JAVASCRIPT_DIALOG_TAB_HELPER_H_ 5 #ifndef CHROME_BROWSER_UI_JAVASCRIPT_DIALOGS_JAVASCRIPT_DIALOG_TAB_HELPER_H_
6 #define CHROME_BROWSER_UI_JAVASCRIPT_DIALOGS_JAVASCRIPT_DIALOG_TAB_HELPER_H_ 6 #define CHROME_BROWSER_UI_JAVASCRIPT_DIALOGS_JAVASCRIPT_DIALOG_TAB_HELPER_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/callback_forward.h" 10 #include "base/callback_forward.h"
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 const base::string16& default_prompt_text, 46 const base::string16& default_prompt_text,
47 const DialogClosedCallback& callback, 47 const DialogClosedCallback& callback,
48 bool* did_suppress_message) override; 48 bool* did_suppress_message) override;
49 void RunBeforeUnloadDialog(content::WebContents* web_contents, 49 void RunBeforeUnloadDialog(content::WebContents* web_contents,
50 bool is_reload, 50 bool is_reload,
51 const DialogClosedCallback& callback) override; 51 const DialogClosedCallback& callback) override;
52 bool HandleJavaScriptDialog(content::WebContents* web_contents, 52 bool HandleJavaScriptDialog(content::WebContents* web_contents,
53 bool accept, 53 bool accept,
54 const base::string16* prompt_override) override; 54 const base::string16* prompt_override) override;
55 void CancelDialogs(content::WebContents* web_contents, 55 void CancelDialogs(content::WebContents* web_contents,
56 bool suppress_callbacks,
57 bool reset_state) override; 56 bool reset_state) override;
58 57
59 // WebContentsObserver: 58 // WebContentsObserver:
60 void WasHidden() override; 59 void WasHidden() override;
61 void DidStartNavigation( 60 void DidStartNavigation(
62 content::NavigationHandle* navigation_handle) override; 61 content::NavigationHandle* navigation_handle) override;
63 void DidStartNavigationToPendingEntry( 62 void DidStartNavigationToPendingEntry(
64 const GURL& url, 63 const GURL& url,
65 content::ReloadType reload_type) override; 64 content::ReloadType reload_type) override;
66 65
(...skipping 29 matching lines...) Expand all
96 // itself calls it, but in the cases where the dialog is closed not by the 95 // itself calls it, but in the cases where the dialog is closed not by the
97 // user's input but by a call to |CloseDialog|, this class will call it. 96 // user's input but by a call to |CloseDialog|, this class will call it.
98 content::JavaScriptDialogManager::DialogClosedCallback dialog_callback_; 97 content::JavaScriptDialogManager::DialogClosedCallback dialog_callback_;
99 98
100 base::Closure dialog_shown_; 99 base::Closure dialog_shown_;
101 100
102 DISALLOW_COPY_AND_ASSIGN(JavaScriptDialogTabHelper); 101 DISALLOW_COPY_AND_ASSIGN(JavaScriptDialogTabHelper);
103 }; 102 };
104 103
105 #endif // CHROME_BROWSER_UI_JAVASCRIPT_DIALOGS_JAVASCRIPT_DIALOG_TAB_HELPER_H_ 104 #endif // CHROME_BROWSER_UI_JAVASCRIPT_DIALOGS_JAVASCRIPT_DIALOG_TAB_HELPER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698