Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: components/app_modal/javascript_dialog_manager.cc

Issue 2639893002: Clean up unneeded JavaScript dialog parameter. (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/app_modal/javascript_dialog_manager.cc
diff --git a/components/app_modal/javascript_dialog_manager.cc b/components/app_modal/javascript_dialog_manager.cc
index 561555a52584cfabfe3bfaacf3227410270d578c..54f3afb4360f297e0d718827e61241ffbd04df8f 100644
--- a/components/app_modal/javascript_dialog_manager.cc
+++ b/components/app_modal/javascript_dialog_manager.cc
@@ -268,7 +268,6 @@ bool JavaScriptDialogManager::HandleJavaScriptDialog(
}
void JavaScriptDialogManager::CancelDialogs(content::WebContents* web_contents,
- bool suppress_callbacks,
bool reset_state) {
AppModalDialogQueue* queue = AppModalDialogQueue::GetInstance();
AppModalDialog* active_dialog = queue->active_dialog();
@@ -279,10 +278,10 @@ void JavaScriptDialogManager::CancelDialogs(content::WebContents* web_contents,
if ((*i) == active_dialog)
continue;
if ((*i)->web_contents() == web_contents)
- (*i)->Invalidate(suppress_callbacks);
+ (*i)->Invalidate();
}
if (active_dialog && active_dialog->web_contents() == web_contents)
- active_dialog->Invalidate(suppress_callbacks);
+ active_dialog->Invalidate();
if (reset_state)
javascript_dialog_extra_data_.erase(web_contents);
« no previous file with comments | « components/app_modal/javascript_dialog_manager.h ('k') | content/browser/devtools/protocol/devtools_protocol_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698