extensions/browser/guest_view/web_view/javascript_dialog_helper.cc - Issue 2639893002: Clean up unneeded JavaScript dialog parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/web_view/javascript_dialog_helper.cc

Issue 2639893002: Clean up unneeded JavaScript dialog parameter. (Closed)

Patch Set: rebase Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/guest_view/web_view/javascript_dialog_helper.cc

diff --git a/extensions/browser/guest_view/web_view/javascript_dialog_helper.cc b/extensions/browser/guest_view/web_view/javascript_dialog_helper.cc

index 9a9763d347f2b3a2c1b96b9fcb3daecd14882d57..200559ccf3e355879f9f9fedf704d70ed8df9960 100644

--- a/extensions/browser/guest_view/web_view/javascript_dialog_helper.cc

+++ b/extensions/browser/guest_view/web_view/javascript_dialog_helper.cc

@@ -86,7 +86,6 @@ bool JavaScriptDialogHelper::HandleJavaScriptDialog(

}

void JavaScriptDialogHelper::CancelDialogs(content::WebContents* web_contents,

- bool suppress_callbacks,

bool reset_state) {}

void JavaScriptDialogHelper::OnPermissionResponse(

« no previous file with comments | « extensions/browser/guest_view/web_view/javascript_dialog_helper.h ('k') | no next file » | no next file with comments »