Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: components/app_modal/javascript_dialog_manager.h

Issue 2639893002: Clean up unneeded JavaScript dialog parameter. (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_APP_MODAL_JAVASCRIPT_DIALOG_MANAGER_H_ 5 #ifndef COMPONENTS_APP_MODAL_JAVASCRIPT_DIALOG_MANAGER_H_
6 #define COMPONENTS_APP_MODAL_JAVASCRIPT_DIALOG_MANAGER_H_ 6 #define COMPONENTS_APP_MODAL_JAVASCRIPT_DIALOG_MANAGER_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 const base::string16& default_prompt_text, 49 const base::string16& default_prompt_text,
50 const DialogClosedCallback& callback, 50 const DialogClosedCallback& callback,
51 bool* did_suppress_message) override; 51 bool* did_suppress_message) override;
52 void RunBeforeUnloadDialog(content::WebContents* web_contents, 52 void RunBeforeUnloadDialog(content::WebContents* web_contents,
53 bool is_reload, 53 bool is_reload,
54 const DialogClosedCallback& callback) override; 54 const DialogClosedCallback& callback) override;
55 bool HandleJavaScriptDialog(content::WebContents* web_contents, 55 bool HandleJavaScriptDialog(content::WebContents* web_contents,
56 bool accept, 56 bool accept,
57 const base::string16* prompt_override) override; 57 const base::string16* prompt_override) override;
58 void CancelDialogs(content::WebContents* web_contents, 58 void CancelDialogs(content::WebContents* web_contents,
59 bool suppress_callbacks,
60 bool reset_state) override; 59 bool reset_state) override;
61 60
62 private: 61 private:
63 friend struct base::DefaultSingletonTraits<JavaScriptDialogManager>; 62 friend struct base::DefaultSingletonTraits<JavaScriptDialogManager>;
64 63
65 JavaScriptDialogManager(); 64 JavaScriptDialogManager();
66 ~JavaScriptDialogManager() override; 65 ~JavaScriptDialogManager() override;
67 66
68 // Wrapper around OnDialogClosed; logs UMA stats before continuing on. 67 // Wrapper around OnDialogClosed; logs UMA stats before continuing on.
69 void OnBeforeUnloadDialogClosed(content::WebContents* web_contents, 68 void OnBeforeUnloadDialogClosed(content::WebContents* web_contents,
(...skipping 19 matching lines...) Expand all
89 // dialogs. (Since Javascript dialogs are modal, this is even accurate!) 88 // dialogs. (Since Javascript dialogs are modal, this is even accurate!)
90 base::TimeTicks last_close_time_; 89 base::TimeTicks last_close_time_;
91 base::TimeTicks last_creation_time_; 90 base::TimeTicks last_creation_time_;
92 91
93 DISALLOW_COPY_AND_ASSIGN(JavaScriptDialogManager); 92 DISALLOW_COPY_AND_ASSIGN(JavaScriptDialogManager);
94 }; 93 };
95 94
96 } // namespace app_modal 95 } // namespace app_modal
97 96
98 #endif // COMPONENTS_APP_MODAL_JAVASCRIPT_DIALOG_MANAGER_H_ 97 #endif // COMPONENTS_APP_MODAL_JAVASCRIPT_DIALOG_MANAGER_H_
OLDNEW
« no previous file with comments | « components/app_modal/javascript_app_modal_dialog.cc ('k') | components/app_modal/javascript_dialog_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698